-
Notifications
You must be signed in to change notification settings - Fork 96
feat: Social rpc client #4615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Social rpc client #4615
Conversation
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: More |
...ploreV2/Scripts/Sections/PlacesAndEventsSection/PlacesAndEventsSectionComponentController.cs
Outdated
Show resolved
Hide resolved
...ploreV2/Scripts/Sections/PlacesAndEventsSection/PlacesAndEventsSectionComponentController.cs
Outdated
Show resolved
Hide resolved
...ploreV2/Scripts/Sections/PlacesAndEventsSection/PlacesAndEventsSectionComponentController.cs
Outdated
Show resolved
Hide resolved
...y-renderer/Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/FriendsController.cs
Outdated
Show resolved
Hide resolved
...y-renderer/Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/FriendsController.cs
Outdated
Show resolved
Hide resolved
...ssets/Scripts/MainScripts/DCL/Controllers/FriendsController/Tests/FriendsControllerShould.cs
Outdated
Show resolved
Hide resolved
...cripts/MainScripts/DCL/Controllers/FriendsController/Tests/Helpers/FriendsController_Mock.cs
Outdated
Show resolved
Hide resolved
...Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/WebInterfaceFriendsApiBridge.cs
Outdated
Show resolved
Hide resolved
...nderer/Assets/Scripts/MainScripts/DCL/Controllers/UserContextMenu/Scripts/UserContextMenu.cs
Show resolved
Hide resolved
...Scripts/MainScripts/DCL/Environment/Factories/ServiceLocatorFactory/ServiceLocatorFactory.cs
Outdated
Show resolved
Hide resolved
...y-renderer/Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/FriendsController.cs
Outdated
Show resolved
Hide resolved
...y-renderer/Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/FriendsController.cs
Outdated
Show resolved
Hide resolved
...y-renderer/Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/FriendsController.cs
Outdated
Show resolved
Hide resolved
...y-renderer/Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/FriendsController.cs
Show resolved
Hide resolved
...-renderer/Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/RPCSocialApiBridge.cs
Outdated
Show resolved
Hide resolved
...-renderer/Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/RPCSocialApiBridge.cs
Outdated
Show resolved
Hide resolved
...-renderer/Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/RPCSocialApiBridge.cs
Outdated
Show resolved
Hide resolved
...ssets/Scripts/MainScripts/DCL/Controllers/FriendsController/Tests/FriendsControllerShould.cs
Outdated
Show resolved
Hide resolved
...Assets/Scripts/MainScripts/DCL/Controllers/FriendsController/WebInterfaceFriendsApiBridge.cs
Outdated
Show resolved
Hide resolved
...ts/Scripts/MainScripts/DCL/Controllers/HUD/FriendsHUD/Tests/FriendsHUDComponentViewShould.cs
Outdated
Show resolved
Hide resolved
f6350d3
to
502d692
Compare
502d692
to
d324399
Compare
...sets/Scripts/MainScripts/DCL/Controllers/FriendsController/Tests/RPCSocialApiBridgeShould.cs
Outdated
Show resolved
Hide resolved
Stale review, already have approval of another TL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️Friends list and current friend requests are available in their appropriate menus.
✔️All friend-related flows work correctly. Accepting and rejecting requests deletes the entry from the requests list and unfriending someone deletes them from the friends list.
Signed-off-by: jmoguilevsky <jmoguilevsky@gmail.com>
This was reverted because it was squashed, it was duplicated and merged into dev properly here: #5125 |
What does this PR change?
This PR introduces the architecture for a new RPC client for the social service,
And it also introduces a feature flag (
use-social-client
) to prevent any unfinished from getting into production.The solution also implied a few architectural changes in the project's codebase:
ISocialApiBridge
and receives aProxySocialApiBridge
that has the sole responsibility of knowing whether to call or not the RPC Client depending on the availability of the feature flag or notInitializeAsync
and assigns the corresponding Actions for the friendships initialization the old bridge or the social one, depending on the feature flag.RequestFriendshipAsync
andRejectFriendshipAsync
as an example of how the client will be used in the future.How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md