Skip to content

fix: stop remote emote on player blocked #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

lorenzo-ranciaffi
Copy link
Contributor

@lorenzo-ranciaffi lorenzo-ranciaffi commented Apr 15, 2025

Pull Request Description

Fixes #3745

When a user is emoting and they got blocked, the blocking user is still able to see the emote props (if it had any).

What does this PR change?

This PR stops the remote emote for blocked players if they were emoting while the user blocked them. By doing so, the props disappear.
It also clears the MultiplayerEmotesMessageBus.messageDeduplication in order to be able to play a remote emote if the blocked user gets unblocked while emoting.

Test Instructions

Prerequisites

  • This is easily tested if you can control 2 avatars A and B

Test Steps

  1. Place A and B in the same place
  2. Start a looping emote with props with both A and B
  3. From A, block B
  4. Verify that A can't see B and their emote props (the same applies from B to A)
  5. From A, unblock B
  6. Verify that A can see B and that shortly after, the emote starts playing as normal (the same applies from B to A)

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@lorenzo-ranciaffi lorenzo-ranciaffi marked this pull request as ready for review April 15, 2025 09:08
@lorenzo-ranciaffi lorenzo-ranciaffi requested review from a team as code owners April 15, 2025 09:08
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • [✔️ ] Backpack and wearables in world
  • [✔️ ] Emotes in world and in backpack
  • [✔️ ]Teleport with map/coordinates/Jump In
  • [✔️ ] Chat and multiplayer
  • [✔️ ] Profile card
  • [✔️ ] Camera
  • [✔️ ] Skybox

Evidence:

15.04.2025_11.37.56_REC.mp4

@lorenzo-ranciaffi lorenzo-ranciaffi enabled auto-merge (squash) April 15, 2025 10:42
@lorenzo-ranciaffi lorenzo-ranciaffi merged commit 4338244 into dev Apr 15, 2025
12 of 15 checks passed
@lorenzo-ranciaffi lorenzo-ranciaffi deleted the fix/remove-emote-props-of-blocked-users branch April 15, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emote props visible after blocking a user
4 participants