Add some profiling markers for MediaPlayer #3883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dalkia,
Ludmilafantaniella and
NickKhalow
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
dalkia
approved these changes
Apr 9, 2025
DafGreco
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- ✅ Backpack and wearables in world
- ✅Emotes in world and in backpack
- ✅Teleport with map/coordinates/Jump In
- ✅ Chat and multiplayer
- ✅ Profile card
- ✅ Camera
- ✅ Skybox
- ✅ Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
This change adds some profiling markers around MediaPlayer calls that I suspect can take a long time. MediaPlayerSystem shows up in the profiler a lot, and this is to narrow down the cause.
Test Instructions
Visit a scene with video textures and see that they still work.
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.