feat: KTX textures & conversion support #3875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New build in progress, come back later! |
mihakrajnc
changed the title
mihakrajnc
force-pushed
the
feat/ktx_textures_and_video_support
branch
from
e7b5b74 to
8309a22
Compare
Ludmilafantaniella
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
🟢 Tested on both Windows and Mac.
The scene “Unity Café...” no contains any SVGs — it looks like they were already removed.
I was able to test the other scene located at 8,117, and everything looks good 👌
nonNFT.mp4
Also a smoke test was performed on other scenes with NFT to ensure that all images (including on the popup) display correctly.
- Genesis Plaza (NFT HALLWAY)
- Rapture Art Gallery
NFT.mp4
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- ✔️ Backpack and wearables in world
- ✔️ Emotes in world and in backpack
- ✔️ Teleport with map/coordinates/Jump In
- ✔️ Chat and multiplayer
- ✔️ Profile card
dalkia
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
We now convert all remote textures to a GPU friendly format (KTX2), with our new dapps converter. Each texture that is requested directly from a remote URL is routed through the converter which will return a KTX texture instead of the original (png / jpg / gif / svg). If the requested image is an animation such as gif, the converter will produce an MP4 video (support for that will be in a separate PR). All conversions are cached on the server - first conversion might take a while but after that it's practically instantaneous.
What does this PR change?
GetTextureWebRequest, which handles all remote textures, will now route url's through our dapps converter.
closes #3273
clases #3200
Test Instructions
Ensure all NFT images (including on the popup) display correctly (minus gifs / videos), and that the server conversion doesn't lock up when there are many requests.
This is also a very good opportunity to use Charles and monitor requests to https://media-opticonverter.decentraland.org, you'll be able to quickly see if the requests are being processed properly.
Test Steps
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.