Fix: profile thumbnail loading inconsitencies #3864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
github-actions
bot
requested review from
davidejensen,
Ludmilafantaniella and
mikhail-dcl
mihakrajnc
approved these changes
Apr 7, 2025
DafGreco
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- ✅ Backpack and wearables in world
- ✅ Emotes in world and in backpack
- ✅ Teleport with map/coordinates/Jump In
- ✅ Chat and multiplayer
- ✅ Profile card
- ✅ Camera
- ✅ Settings
lorenzo-ranciaffi
deleted the
fix/profile-thumbnail-loading-inconsitencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #3762
Profile thumbnail images sometime appear as if they failed to load (especially in the nearby users section). This is caused by the UI redrawing and cancelling the loading process multiple times.
Also, the loading spinners in the PhotoDetail panel and in the friend list panel are not animating while waiting for the thumbnail.
What does this PR change?
This PR prevents the cancellation of the loading task when we are trying to redraw the same user, letting the normal loading flow to continue and solve the thumbnails.
Regarding the animation, the wrong material was being used therefore the shader that animates the spinner wasn't working.
Test Steps
Verify that all thumbnails are loaded (also, the loading spinners should be animating while loading) in the following panels:
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.