Skip to content

Fix: terrain hide cause IndexOutOfRange exception #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025

Conversation

popuz
Copy link
Collaborator

@popuz popuz commented Apr 7, 2025

Pull Request Description

Fix Sentry reported exception by adding range check.

additionally (temproarly) disables speed-up logic for multiplayer movement

Test

  1. Jump from between genesis and world - terrain should be rendered normally

Separately:

  1. Check that remote players around are interpolated normally as previously

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@popuz popuz added the no QA needed Used to tag pull requests that does not require QA validation label Apr 7, 2025
@popuz popuz self-assigned this Apr 7, 2025
@popuz popuz requested review from a team as code owners April 7, 2025 08:55
@popuz popuz removed the no QA needed Used to tag pull requests that does not require QA validation label Apr 7, 2025
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • ✅ Backpack and wearables in world
  • ✅ Emotes in world and in backpack
  • ✅ Teleport with map/coordinates/Jump In
  • ✅ friends
  • ✅ Profile card
  • ✅ Camera
  • ✅Skybox

No new issues found during this test

@m3taphysics m3taphysics merged commit 1436a6b into dev Apr 7, 2025
6 checks passed
@m3taphysics m3taphysics deleted the fix/terrain-colliders-index-out-of-range branch April 7, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants