Skip to content

feat: add min spec guard panel at load #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2025
Merged

Conversation

davidejensen
Copy link
Member

@davidejensen davidejensen commented Apr 4, 2025

Pull Request Description

What does this PR change?

Fix #2887
This PR implements a screen shown at start time that notifies the user they don't have met the minimum hardward requirements to run DCL, it still lets them play.
Screenshot 2025-04-11 at 09 05 56

Test Instructions

Test Steps

First test:

  1. Launch the build with a computer that has more than the minimum hardware requirements
  2. Verify that it loads fine

Second test:

  1. Launch the build with a computer that has less than the minimum hardware requirements, if you don't have one you can launch the build via terminal with the parameter --forceMinimumSpecsScreen to simulate it
  2. Verify that during the initial loading a screen appears stating the minimum requirements
  3. Verify that all the buttons work as expected

@davidejensen davidejensen self-assigned this Apr 4, 2025
Copy link
Contributor

github-actions bot commented Apr 4, 2025

@davidejensen davidejensen marked this pull request as ready for review April 11, 2025 07:06
@davidejensen davidejensen requested review from a team as code owners April 11, 2025 07:06
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • ✔️ Backpack and wearables in world
  • ✔️ Emotes in world and in backpack
  • ✔️ Teleport with map/coordinates/Jump In
  • ✔️ Profile card
  • ✔️ Camera
  • ✔️ Skybox
  • ✔️ Settings

Copy link
Contributor

@lorenzo-ranciaffi lorenzo-ranciaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only a small issue for the failing test

@davidejensen davidejensen merged commit 52daaf3 into dev Apr 11, 2025
7 of 8 checks passed
@davidejensen davidejensen deleted the feat/min-spec-warning branch April 11, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum Specificication Warning
3 participants