fix: chat spam performance issue & own profile picture #3635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
lorux0
requested review from
fcolarich
and removed request for
popuz and
mikhail-dcl
fcolarich
approved these changes
Mar 19, 2025
lorux0
changed the title
m3taphysics
approved these changes
Mar 20, 2025
fcolarich
approved these changes
Mar 20, 2025
anicalbano
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
✔️ Verified by QA, profile pics are visible in all areas. Checked:
- Chat convo
- Mention
- Profile pic on nav bar
- Pic on Add Friend/Friend inside Profile
- Onside the options bar
- When sending Friend requests
- When acceptin
- Inside friends/requests/blocked
20.03.2025_15.25.20_REC.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fixes a major performance issue while spamming the chat.
Profile pictures for own chat messages were not working because the loading state was not correctly calculated. The chat system sets the profile picture many times in a row and this provokes to cancel the operation in between. We dont consider the load state anymore in the process. We just set the sprite if its already in the cache.
Test Instructions
Spam messages in the chat. Check that you can see your own profile picture. Check that you don't have performance issues.
Check profile pictures in other places, like friends, sidebar, passport, etc.
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.