-
Notifications
You must be signed in to change notification settings - Fork 13
JavaScript profiler module #3611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
Explorer/Assets/DCL/PerformanceAndDiagnostics/Analytics/Systems/PerformanceAnalyticsSystem.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Did you check if enabling this js-debugging decrease performance?
Main request is to report at least some part of this js data to Analytics. Probably AllScenesTotalHeapSize
and currentScene.TotalHeapSize
Explorer/Assets/DCL/PerformanceAndDiagnostics/Analytics/Systems/PerformanceAnalyticsSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/PerformanceAndDiagnostics/Profiling/ECS/DebugViewProfilingSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/PerformanceAndDiagnostics/Profiling/ECS/DebugViewProfilingSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/PerformanceAndDiagnostics/Profiling/ECS/DebugViewProfilingSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/PerformanceAndDiagnostics/Profiling/ECS/DebugViewProfilingSystem.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Reviewed by QA. The pannel works as expected!
18.03.2025_16.01.04_REC.mp4
Explorer/Assets/DCL/PerformanceAndDiagnostics/Analytics/Systems/PerformanceAnalyticsSystem.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Thanks for applying changes and bringing analytics back!
Pull Request Description
What does this PR change?
This change adds profiler performance counters for JavaScript and gets rid of some code bureaucracy.
Test Instructions
Play normally and see that this debug panel works and shows plausible numbers. Check "enable scene metrics" to see the numbers.

Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.