Skip to content

JavaScript profiler module #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 20, 2025
Merged

JavaScript profiler module #3611

merged 8 commits into from
Mar 20, 2025

Conversation

AnsisMalins
Copy link
Collaborator

Pull Request Description

What does this PR change?

This change adds profiler performance counters for JavaScript and gets rid of some code bureaucracy.

Test Instructions

Play normally and see that this debug panel works and shows plausible numbers. Check "enable scene metrics" to see the numbers.
image

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@AnsisMalins AnsisMalins requested review from a team as code owners March 18, 2025 11:02
Copy link
Contributor

github-actions bot commented Mar 18, 2025

Copy link
Collaborator

@popuz popuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you check if enabling this js-debugging decrease performance?
Main request is to report at least some part of this js data to Analytics. Probably AllScenesTotalHeapSize and currentScene.TotalHeapSize

Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Reviewed by QA. The pannel works as expected!

18.03.2025_16.01.04_REC.mp4

Copy link
Collaborator

@popuz popuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks for applying changes and bringing analytics back!

@AnsisMalins AnsisMalins merged commit 6e625b4 into dev Mar 20, 2025
7 checks passed
@AnsisMalins AnsisMalins deleted the feat/javascript-profiler-module branch March 20, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants