-
Notifications
You must be signed in to change notification settings - Fork 13
feat: sdk virtual camera FOV #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2025
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
anicalbano
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Reviewed and approved by QA both in Mac and Windows. The checks made where the cases listed on the ticket:
- Normal character camera
- Camera with FOV 45 (distant camera)
- Camera with FOV 30 (distant camera with more zoom)
- Camera with FOV 15 (distant camera with more~more zoom)
- Leaving the scene and check that the camera goes back to normal
- Teleport again to GP and check that everything works as expected
lorenzo-ranciaffi
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
FOV
parameter of SDK virtual camerasMainCameraSystem.ApplyVirtualCamera()
to do only 1entitiesMap
lookup and only 1World.TryGet()
for the Virtual Camera components on the entityRelated PRs:
TEST INSTRUCTIONS
pravus.dcl.eth
worldScreen.Recording.2025-03-18.at.10.41.23.PM.mp4