Skip to content

feat: sdk virtual camera FOV #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 19, 2025
Merged

feat: sdk virtual camera FOV #3487

merged 9 commits into from
Mar 19, 2025

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Mar 5, 2025

WHAT

  • Implemented support for new experimental FOV parameter of SDK virtual cameras
  • Optimized MainCameraSystem.ApplyVirtualCamera() to do only 1 entitiesMap lookup and only 1 World.TryGet() for the Virtual Camera components on the entity

Related PRs:

TEST INSTRUCTIONS

  1. Download the build from this PR
  2. Open it and go to the pravus.dcl.eth world
  3. Once inside the scene, confirm that every time you press the E key, you switch between these 4 cameras (you won't be able to confirm the exact FOV value, just confirm that the zoom increases and in the end you return to the normal cam):
    • Normal character camera
    • Camera with FOV 45 (distant camera)
    • Camera with FOV 30 (distant camera with more zoom)
    • Camera with FOV 15 (distant camera with more~more zoom)
  4. Change again between the cameras but this time confirm that when a virtual camera with zoom is active, if you leave the scene, you return to your normal character camera, and if you enter again, the virtual camera becomes active again.
Screen.Recording.2025-03-18.at.10.41.23.PM.mp4

Copy link
Contributor

github-actions bot commented Mar 5, 2025

@pravusjif pravusjif added the force-build Used to trigger a build on draft PR label Mar 5, 2025
@pravusjif pravusjif moved this from Todo to In Progress in Creators Tools Mar 5, 2025
@pravusjif pravusjif moved this from Todo to In Progress in Explorer Alpha Mar 5, 2025
@pravusjif pravusjif added feature a new feature sdk force-build Used to trigger a build on draft PR and removed force-build Used to trigger a build on draft PR labels Mar 5, 2025
@pravusjif pravusjif added force-build Used to trigger a build on draft PR and removed force-build Used to trigger a build on draft PR labels Mar 18, 2025
@pravusjif pravusjif marked this pull request as ready for review March 18, 2025 22:39
@pravusjif pravusjif requested review from a team as code owners March 18, 2025 22:39
@github-actions github-actions bot requested review from DafGreco and dalkia March 18, 2025 22:39
@github-actions github-actions bot requested a review from lorux0 March 18, 2025 22:39
@pravusjif pravusjif requested review from lorenzo-ranciaffi and removed request for a team, dalkia and lorux0 March 18, 2025 22:39
@pravusjif pravusjif moved this from In Progress to QA in Creators Tools Mar 18, 2025
@pravusjif pravusjif moved this from In Progress to With QA / Awaiting Review in Explorer Alpha Mar 18, 2025
@pravusjif pravusjif removed the force-build Used to trigger a build on draft PR label Mar 18, 2025
@pravusjif pravusjif requested review from anicalbano and removed request for DafGreco March 18, 2025 22:40
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Reviewed and approved by QA both in Mac and Windows. The checks made where the cases listed on the ticket:

  • Normal character camera
  • Camera with FOV 45 (distant camera)
  • Camera with FOV 30 (distant camera with more zoom)
  • Camera with FOV 15 (distant camera with more~more zoom)
  • Leaving the scene and check that the camera goes back to normal
  • Teleport again to GP and check that everything works as expected

@github-project-automation github-project-automation bot moved this from With QA / Awaiting Review to In Progress in Explorer Alpha Mar 19, 2025
@pravusjif pravusjif moved this from In Progress to With QA / Awaiting Review in Explorer Alpha Mar 19, 2025
@pravusjif pravusjif merged commit 1c21edc into dev Mar 19, 2025
6 checks passed
@pravusjif pravusjif deleted the feat/sdk-virtual-camera-fov branch March 19, 2025 23:12
@github-project-automation github-project-automation bot moved this from With QA / Awaiting Review to Done in Explorer Alpha Mar 19, 2025
@github-project-automation github-project-automation bot moved this from QA to Done in Creators Tools Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a new feature sdk
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants