Skip to content

feat: implement analytics with renderer protocol #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuruk-mm merged 3 commits into from
Nov 30, 2022
Merged

feat: implement analytics with renderer protocol #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
725c7c9
feat: implement `analytics` with renderer protocol
kuruk-mm Nov 22, 2022
4d33ec6
unseigned to signed
kuruk-mm Nov 28, 2022
8ac153c
Merge branch 'main' into feat/analytics
kuruk-mm Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions proto/decentraland/renderer/kernel_services/analytics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
syntax = "proto3";

package decentraland.renderer.kernel_services;

message PerformanceReportRequest {
string samples = 1;
bool fps_is_capped = 2;
sfixed32 hiccups_in_thousand_frames = 3;
float hiccups_time = 4;
float total_time = 5;
sfixed32 gltf_in_progress = 6;
sfixed32 gltf_failed = 7;
sfixed32 gltf_cancelled = 8;
sfixed32 gltf_loaded = 9;
sfixed32 ab_in_progress = 10;
sfixed32 ab_failed = 11;
sfixed32 ab_cancelled = 12;
sfixed32 ab_loaded = 13;
sfixed32 gltf_textures_loaded = 14;
sfixed32 ab_textures_loaded = 15;
sfixed32 promise_textures_loaded = 16;
sfixed32 enqueued_messages = 17;
sfixed32 processed_messages = 18;
sfixed32 player_count = 19;
sfixed32 load_radius = 20;
sfixed32 draw_calls = 21; //int32 *
sfixed64 memory_reserved = 22; //long, in total bytes *
sfixed64 memory_usage = 23; //long, in total bytes *
sfixed64 total_gc_alloc = 24; //long, in total bytes, its the sum of all GCAllocs per frame over 1000 frames *
map<sfixed64, sfixed64> scene_scores = 25;
}

message PerformanceReportResponse {}

message SystemInfoReportRequest {
string graphics_device_name = 1;
string graphics_device_version = 2;
fixed32 graphics_memory_size = 3;
string processor_type = 4;
fixed32 processor_count = 5;
fixed32 system_memory_size = 6;

// TODO: remove useBinaryTransform after ECS7 is fully in prod
bool use_binary_transform = 7;

@pbosio pbosio Nov 29, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could remove this already and safely assume renderer will always expect a binary transform, since a really loooong time has passed since we did that change

}

message SystemInfoReportResponse {}

message AnalyticProperty {
string key = 1;
string value = 2;
}

message AnalyticsEventRequest {
string event_name = 1;
repeated AnalyticProperty properties = 2;
}

message AnalyticsEventResponse {}

message DelightedSurveyRequest {
bool enabled = 1;
}

message DelightedSurveyResponse {}

service AnalyticsKernelService {
rpc PerformanceReport(PerformanceReportRequest) returns (PerformanceReportResponse) {}
rpc SystemInfoReport(SystemInfoReportRequest) returns (SystemInfoReportResponse) {}
rpc AnalyticsEvent(AnalyticsEventRequest) returns (AnalyticsEventResponse) {}
rpc SetDelightedSurveyEnabled(DelightedSurveyRequest) returns (DelightedSurveyResponse) {}
}
3 changes: 2 additions & 1 deletion public/renderer-interface.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ import public "decentraland/renderer/engine_interface.proto";
import public "decentraland/renderer/renderer_services/crdt.proto";
import public "decentraland/renderer/renderer_services/transport.proto";
import public "decentraland/renderer/renderer_services/emotes_renderer.proto";
import public "decentraland/renderer/kernel_services/emotes_kernel.proto";
import public "decentraland/renderer/kernel_services/emotes_kernel.proto";
import public "decentraland/renderer/kernel_services/analytics.proto";