Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui-background not setting the region rect and not hiding display:none #195

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Jan 25, 2024

  • fix: ui-background not setting the region
  • fix: not hiding display:none
  • use Headers object in the fetch response

@codecov-commenter
Copy link

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (c249172) 48.33% compared to head (47c0f48) 48.36%.

Files Patch % Lines
...d-godot-lib/src/godot_classes/dcl_ui_background.rs 9.52% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   48.33%   48.36%   +0.02%     
==========================================
  Files         141      141              
  Lines       17161    17169       +8     
==========================================
+ Hits         8294     8303       +9     
+ Misses       8867     8866       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza merged commit 7956d11 into main Jan 25, 2024
3 checks passed
@leanmendoza leanmendoza deleted the fix/ui-bakcground-regionrect branch January 25, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants