feat: mobile main hud #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kuruk-mm
commented
Jan 16, 2024
•
kuruk-mm
commented
- Change Icons in the HUD
- Screen scaling. The base resolution for the UI is 1280x720, and if you change the size, the UI will resize to match that size.
- Menu navigation UI improved, header increased the size
- Joystick now works in an left-bottom area of the screen
- Chat only is shown when it's used (on the future, we are going to implement last 5 messages notifications above it)
- Implement SafeAreaHUD, an area that the "interactive" UI must be drawn. This is for avoiding physicals parts in the Mobile phone (like a camera, or some parts of it) that you cannot interact
kuruk-mm
force-pushed
the
feat/mobile-main-hud
branch
from
e4359f9
to
904b8b6
Compare
kuruk-mm
force-pushed
the
feat/mobile-main-hud
branch
from
95856cd
to
501d84a
Compare
leanmendoza
requested changes
Jan 18, 2024
godot/src/main.gd
Outdated
| ) | ||
| resolution_manager.change_resolution(get_window(), get_viewport(), Global.config.resolution) | ||
| resolution_manager.change_ui_scale(get_window(), Global.config.ui_scale) | ||
| #resolution_manager.change_window_size( |
There was a problem hiding this comment.
dead code
this is still in the settings
| @@ -73,8 +73,12 @@ func _ready() -> void: | |||
| hide() | |||
|
|
|||
|
|
|||
| func custom_input(event: InputEvent) -> void: | |||
There was a problem hiding this comment.
can you detail how this works?
godot/src/ui/components/safe_margin_container/SafeMarginContainer.gd
Outdated
Show resolved
Hide resolved
kuruk-mm
force-pushed
the
feat/mobile-main-hud
branch
from
5fd57f6
to
a201885
Compare
fix: remove incorrect code from virtual joystick, that was already there fix: safe area margin now works correctly
leanmendoza
approved these changes
Jan 19, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 47.37% 47.40% +0.02%
==========================================
Files 140 140
Lines 16850 16868 +18
==========================================
+ Hits 7983 7996 +13
- Misses 8867 8872 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.