Fix(#7442): dynamic loading of codemirror language modes#7443
Merged
Conversation
yanthomasdev
approved these changes
Apr 17, 2026
yanthomasdev
left a comment
yanthomasdev
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks. I agree the suggested approach is better, but given current limitations this will do.
sempostma
pushed a commit
to laikacms/decap-cms
that referenced
this pull request
May 23, 2026
…aporg#7443) * fix: dynamic codemirror mode imports * style: format code * fix: await function and add error handling --------- Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the code widget does not work properly in ESM builds as it calls
require()with a dynamic argument, hence the dynamic loading of language modes is broken (see #7442).This PR fixes this by using a map of loader functions that use dynamic imports with static paths. The map is generated by the same script that creates the
languages.jsonfile.