Add <span> tag to (optional) suffix for customization #7103
Conversation
With the <span> (or any) tag we can add CSS like:
```css
body {
[class*=FieldLabel-fieldLabel] span {
display: none;
}
}
```
to hide or customize the _(optional)_ suffix.
It'll specially useful when majority of the fields are optional, we can also use CSS :has to select required fields and add a _*_ for example.
There was a problem hiding this comment.
@leomp12 this is a good idea. before we can merge this, please fix the lint error.
|
hey @martinjagodic , |
|
Hi @leomp12 lint checker is blaming the |
|
done @demshy 👍🏾 |
There was a problem hiding this comment.
@leomp12 an e2e test is failing: Markdown widget code block. I think there's an extra space after Code Block in the expected code.
|
@leomp12 to find the cause for the test fail easier you can run cypress in dev mode locally with |
* Add <span> tag to (optional) suffix for customization
With the <span> (or any) tag we can add CSS like:
```css
body {
[class*=FieldLabel-fieldLabel] span {
display: none;
}
}
```
to hide or customize the _(optional)_ suffix.
It'll specially useful when majority of the fields are optional, we can also use CSS :has to select required fields and add a _*_ for example.
* Update EditorControl.js
* chore: format
* chore: preventing empty space on field label
* Update EditorControl.js
* test: remove extra space from expected result in e2e test
---------
Co-authored-by: Anze Demsar <anze.demsar@p-m.si>
Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
With the (or any) tag we can add CSS like:
to hide or customize the (optional) suffix.
It'll specially useful when majority of the fields are optional, we can also use CSS :has to select required fields and add a * for example.
Summary
Test plan
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)