-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1896 fetching other collections from preview #6523
1896 fetching other collections from preview #6523
Conversation
Would love to see this feature in Netlify CMS. Anyone from the team interested in taking a look? |
This would be a great feature. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@cdennington are you still interested in moving this forward? |
@martinjagodic I'd happily be involved in pushing this one out, what do you need from me? Other than fixing conflicts |
@cdennington great. Please solve conflicts first and then we will review. Thanks! |
22d09a7
to
134df13
Compare
Signed-off-by: Wigger Boelens <me@wigger.email>
@cdennington linter is failing. Please run |
Signed-off-by: Wigger Boelens <me@wigger.email>
@martinjagodic, cdennington didn't have the time to finish this, so I took over. With the docs moving to a different repo, I guess I should just make a seperate pull request there to add the docs for this? |
Yes please |
Added the pull request for the documentation (written by @cdennington) here: decaporg/decap-website#55. Not sure why the macos build is failing, it seems to get stuck installing dependencies. No changes have been made to those. |
packages/decap-cms-core/src/components/Editor/EditorPreviewPane/EditorPreviewPane.js
Show resolved
Hide resolved
This is great @Boelensman1, MacOS build is a bit cranky sometimes, don't worry about it :) Left you one little question otherwise this is good to go and can be released today/tomorrow with a few other PRs. |
* feat(preview): successfully getting collection by name and slug * feat(blog): cleanup EditorPreviewPane.js * feat(preview): new function added to allow previews to fetch data from other collections * feat(preview): running format and test * feat(preview): add getCollection to types Signed-off-by: Wigger Boelens <me@wigger.email> * feat(preview): fix lint issues Signed-off-by: Wigger Boelens <me@wigger.email> --------- Signed-off-by: Wigger Boelens <me@wigger.email> Co-authored-by: cdennington <charlie@design-id.tech> Co-authored-by: Wigger Boelens <me@wigger.email> Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
Summary
Allowing users to access data from other collections whilst in the preview pane.
See the comments here: #1896
This is my first time contributing to this repo, so I'm not 100% across the code base, so feedback is welcome.
I've tested this on a project I am working on at the moment and it worked as expected:
Checklist
Please add a
x
inside each checkbox:yarn format
.yarn test
.