Migrate to Slate 0.25 #638
Conversation
erquhart
force-pushed
the
slate-0.25
branch
5 times, most recently
from
989cd19 to
976d5d1
Compare
|
@erquhart This is weird -- it looks like the commits are out of order (upgrade to 0.25 comes before 0.22), but when I look at each diff, they are valid, but not in order? If I look at the branch diff it is correct, though. |
| "slate-edit-table": "^0.10.1", | ||
| "slate-soft-break": "^0.3.0", | ||
| "slate": "^0.25.0", | ||
| "slate-edit-list": "^0.8.0", |
There was a problem hiding this comment.
warning "slate-edit-list@0.8.0" has incorrect peer dependency "slate@^0.23.0".
There was a problem hiding this comment.
Yeah, I think that's just where slate-edit-list is at, it's the latest version.
There was a problem hiding this comment.
They do use Block.create() here: https://github.com/GitbookIO/slate-edit-list/tree/master/lib/changes, in decreaseItemDepth.js and increaseItemDepth.js, I don't know if that could present a problem at all.
There was a problem hiding this comment.
There was a problem hiding this comment.
They're manually inserting chlidren, so those created blocks will never have no children. Not an issue. Thanks for checking their source!
| @@ -10,7 +10,11 @@ Object { | |||
| Object { | |||
| "data": undefined, | |||
| "kind": "text", | |||
| "text": "H1", | |||
| "ranges": Array [ | |||
There was a problem hiding this comment.
I didn't see in the changelog exactly why this was needed, could you explain?
There was a problem hiding this comment.
It's actually not in the changelog, but Slate text nodes used to come in two flavors, either they'd have a simple "text" property with the value, or else a "ranges" property having an array of objects representing text with associated marks. They quietly switched to using "ranges" only.
Migrate from Slate 0.21 to 0.25 - related changelog here.