Fix date field persist #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches back to custom frontmatter stringification until support lands in preliminaries. This is necessary because we use custom schemas for certain data types, such as dates and times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches back to custom frontmatter stringification
until support lands in the preliminaries lib. This is necessary
because we use custom schemas for certain data types,
such as dates and times.
(This is a copy of #384 with history rewritten to use @josephearl's alternate implementation).
- Summary
Date fields can no longer be changed through the CMS. Regression from #348.
- Test plan
Moved the Published Date field in the example project out of metadata and into standard fields, so persisting dates can be observed in deploy previews. Tested locally. Existing automated tests pass.
- Description for the changelog
Fix date/datetime field persisting