fix: miscellaneous backend fixes #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit f241bc6 |
|
Deploy preview for cms-demo ready! Built with commit f241bc6 |
7 tasks
erquhart
suggested changes
Aug 6, 2018
| @@ -118,10 +118,15 @@ export default class API { | |||
| return this.processFiles(entries); | |||
| }; | |||
|
|
|||
| uploadBlob = async item => { | |||
| uploadBlob = async (item, { commitMessage, branch = this.branch, author = this.commitAuthor } = {}) => { | |||
There was a problem hiding this comment.
Doesn't look like we're using author, maybe we should remove until there's a use.
There was a problem hiding this comment.
Good catch, it should be added to the commit.
tech4him1
force-pushed
the
misc-backend-fixes
branch
from
f5aece1 to
e369cb8
Compare
tech4him1
changed the title
tech4him1
force-pushed
the
misc-backend-fixes
branch
from
4b40ce0 to
31930ba
Compare
|
@erquhart Updated! |
tech4him1
changed the title
erquhart
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
- Test plan
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)