chore(lint): cleanup unused variables in code #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
changed the title
7 tasks
|
Deploy preview for netlify-cms-www ready! Built with commit ee5d7a3 |
|
Deploy preview for cms-demo ready! Built with commit ee5d7a3 |
tech4him1
force-pushed
the
no-unused-vars
branch
from
61c3323 to
3bfad10
Compare
tech4him1
force-pushed
the
no-unused-vars
branch
from
7d7a124 to
ee5d7a3
Compare
tech4him1
changed the title
erquhart
reviewed
Aug 6, 2018
| @@ -557,7 +557,7 @@ export default class API { | |||
| const contentKey = slug; | |||
| const branchName = this.generateBranchName(contentKey); | |||
| return this.retrieveMetadata(contentKey) | |||
| .then(metadata => this.closePR(metadata.pr, metadata.objects)) | |||
There was a problem hiding this comment.
Looks like we should be removing associated metadata when a PR is closed, but we're not.
There was a problem hiding this comment.
@erquhart Feel free to push a fix for this here, or separately.
erquhart
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused variables in code. I think this should get a fairly thorough review to make sure that there are not hidden bugs if we should have been using these variables.