Repository navigation
Can't set global log() function overriding namespaces ones #873
Description
Activity
Yes but
self.logshouldn't be set to anything.Welcome to Node.js v17.3.1. Type ".help" for more information. > const debug = require('debug'); undefined > debug.log [Function: log] > d1 = debug('foo:bar') [Function: debug] { namespace: 'foo:bar', useColors: true, color: 4, extend: [Function: extend], destroy: [Function: deprecated], enabled: [Getter/Setter], inspectOpts: {} } > d1.log undefined > d1.enabled = true true > d1('test') foo:bar test +0ms undefined > debug.log = (...args) => console.error('MY DEBUG:', ...args); [Function (anonymous)] > d1('test') MY DEBUG: foo:bar test +24s undefinedThis works for me on the latest version. Can you reproduce that locally?
This works for me on the latest version.
It's not the same case here, that works because
d1.logisundefined, but at Mediasoup https://github.com/versatica/mediasoup/blob/4783b3dde93d43b5b120a8088af873aa5661202f/node/src/Logger.ts#L27-L29d1.logis set to a function, the same as what the example in the docs says:Lines 254 to 272 in c0805cc
With
d1.logset to a function asdebugdocumentation example does (and also Mediasoup does too), it fails.How can I help you with that? It's tagged as
question, but it's also a bug on docs and/or actual implementation. How can we move this forward?I'm not sure what you want. If you specify a logger on individual debug instances, of course it will override the global logger. That's well defined.
What behavior would you like to see happen?
What behavior would you like to see happen?
According to the docs example, if you define a logger in debug instance, it will override all the ones from its parent debug instances, but if you define a global logger, it will override all the debug instances. The example in the docs is very explicit about this behaviour:
Lines 254 to 272 in c0805cc
You're right, GitHub has a scrollbar on mobile and I missed it in your other comment. My apologies.
PR welcome to fix the docs. There isn't a great way to fix this that won't break a bunch of people unfortunately. I need to think about how to approach this for v5.
- added and removed
on Mar 8, 2022 Thing is, it seems like this was the previous behaviour, but can't find the actual reference.
2.6.8
4.3.4
On the example located at https://github.com/debug-js/debug#output-streams, it shows that's possible to set custom
log()functions for each namespace, but also that setting it directly on thedebugmodule takes precedence and will be used instead of the namespace ones. This is specially useful in my use case, since I want to capture Mediasoup debuging Logger and redirect it to Moleculer logger. Problem is that according todebug/src/common.js
Lines 112 to 113 in c0805cc
log()function has absolute priority, so it's not possible to do it globally, and it's not possible to directly bind on top of Mediasoup Loggers since they are private, so I'm in an end road.Since the linken example at https://github.com/debug-js/debug/blob/master/examples/node/stdout.js doesn't exists too, I'm not sure if the documentation is outdated or wrong, or if setting
debug.log()should effectively override per-namespacelog()function and this is in fact a bug. Besides fixing this one way or another, how can I solve my problem of redirect Mediasoup log messages to Moleculer?