feat: add kind field for feature type identification #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add FeatureKindEnum with TRACK and POINT values to enable schema-based feature type discrimination. The kind field is required in both TrackProperties and ReferenceLocationProperties, allowing consumers to dispatch to the correct schema based on a single field check. Changes: - Add FeatureKindEnum to common.yaml - Add kind field to TrackProperties (TRACK) and ReferenceLocationProperties (POINT) - Update all test fixtures with kind field - Regenerate Python, TypeScript, and JSON Schema artifacts - Update REP handler to emit kind: TRACK in parsed features
- Add ADR-001 documenting the feature kind discriminator decision, including context, alternatives considered, and consequences - Update data-model.md with FeatureKindEnum section and kind field in both TrackProperties and ReferenceLocationProperties tables - Update JSON examples to include kind field
IanMayo
added a commit
that referenced
this pull request
Jan 20, 2026
- Regenerate Pydantic, JSON Schema, and TypeScript from LinkML annotations - Fix Unicode encoding crash in generate.py and Makefile (replace checkmarks with ASCII) - Add backlog item #20 for deferred ELLIPSE/POLYGON schemas - Reorder backlog by status then score - Remove #19 from STRATEGY.md parking lot All 43 schema tests pass. Completes the code generation portion of backlog #15. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FeatureKindEnum with TRACK and POINT values to enable schema-based feature type discrimination. The kind field is required in both TrackProperties and ReferenceLocationProperties, allowing consumers to dispatch to the correct schema based on a single field check.
Changes: