Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7032 Implement Retries for Amazon Kinesis Event Transmittion #43

Merged
merged 5 commits into from
Oct 30, 2023
Merged

DBZ-7032 Implement Retries for Amazon Kinesis Event Transmittion #43

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b610ffa
DBZ-7032 Implement Retries for Amazon Kinesis Event Transmittion
ilyasahsan123 Oct 13, 2023
713c181
Remove null record condition
ilyasahsan123 Oct 15, 2023
12ce662
The changes are
ilyasahsan123 Oct 16, 2023
860fb62
Format the code style.
ilyasahsan123 Oct 28, 2023
4727862
DBZ-7032 Use Duration type
jpechane Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format the code style.
  • Loading branch information
@ilyasahsan123
ilyasahsan123 committed Oct 28, 2023
commit 860fb62ef79a4f79de76d34b977660530edabd9f
3 changes: 2 additions & 1 deletion debezium-server-kinesis/src/main/java/io/debezium/server/kinesis/KinesisChangeConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ private boolean recordSent(ChangeEvent<Object, Object> record) {
try {
client.putRecord(putRecord);
sent = true;
} catch (SdkClientException exception) {
}
catch (SdkClientException exception) {
LOGGER.error("Failed to send record to {}:", record.destination(), exception);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to log the exception and re-throw. Either you should handle the exception and if you don't handle it, don't catch it a let the caller to handle it (and eventually log the exception)

}
return sent;
Expand Down