DBZ-8043 Support FLOAT32 type #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome as a new contributor to Debezium, @arawind. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively. |
|
Hi @arawind, thanks for your first contribution 🎉. Would you mind also opening a PR in the main https://github.com/debezium/debezium repository with the same issue tag, adding the |
|
Thanks for the quick response @Naros! I've raised debezium/debezium#5668 to update the documentation. |
|
@arawind Applied, thanks! |
|
@nancyxu123 I guess next time we need better use draft functionality. But TBH you're the one who convinced me this is done by asking me for the review :-). |
|
Sorry for the confusion! I'm working on the integration test. I'll create a follow up PR with the test |
arawind
added a commit
to arawind/debezium-connector-spanner
that referenced
this pull request
Jul 11, 2024
This mapping is needed to read the FLOAT32 value from spanner's response. This was missed in debezium#92.
arawind
added a commit
to arawind/debezium-connector-spanner
that referenced
this pull request
Jul 11, 2024
This is a continuation of debezium#92. This IT does not support verifying the float32 values as it is dependent on a change in Cloud Spanner Emulator, and it should be available in the next few emulator releases. This is a test-only issue; running this against production should pass the assertion.
arawind
added a commit
to arawind/debezium-connector-spanner
that referenced
this pull request
Jul 11, 2024
This is a continuation of debezium#92. This IT does not support verifying the float32 values as it is dependent on a change in Cloud Spanner Emulator, and it should be available in the next few emulator releases. This is a test-only issue; running this against production should pass the assertion.
arawind
added a commit
to arawind/debezium-connector-spanner
that referenced
this pull request
Jul 11, 2024
This is a continuation of debezium#92. This IT does not support verifying the float32 values as it is dependent on a change in Cloud Spanner Emulator, and it should be available in the next few emulator releases. This is a test-only issue; running this against production should pass the assertion.
arawind
added a commit
to arawind/debezium-connector-spanner
that referenced
this pull request
Jul 18, 2024
This is a continuation of debezium#92. This IT does not support verifying the float32 values as it is dependent on a change in Cloud Spanner Emulator, and it should be available in the next few emulator releases. This is a test-only issue; running this against production should pass the assertion.
arawind
added a commit
to arawind/debezium-connector-spanner
that referenced
this pull request
Jul 19, 2024
This is a continuation of debezium#92. This IT does not support verifying the float32 values as it is dependent on a change in Cloud Spanner Emulator, and it should be available in the next few emulator releases. This is a test-only issue; running this against production should pass the assertion.
jpechane
pushed a commit
that referenced
this pull request
Aug 2, 2024
This mapping is needed to read the FLOAT32 value from spanner's response. This was missed in #92.
jpechane
pushed a commit
that referenced
this pull request
Aug 2, 2024
This is a continuation of #92. This IT does not support verifying the float32 values as it is dependent on a change in Cloud Spanner Emulator, and it should be available in the next few emulator releases. This is a test-only issue; running this against production should pass the assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spanner now supports the FLOAT32 type. This change creates a mapping between "FLOAT32" / "REAL" to Kafka's FLOAT32_SCHEMA