Skip to content

Added create folder option, fixes (#8) #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2019
Merged

Added create folder option, fixes (#8) #13

merged 3 commits into from
Jan 12, 2019

Conversation

Layman806
Copy link
Contributor

@Layman806 Layman806 commented Jan 12, 2019 •
edited by debck
Loading

Solves #8

Repository owner deleted a comment from TravisBuddy Jan 12, 2019
Repository owner deleted a comment from TravisBuddy Jan 12, 2019
@debck
Copy link
Owner

debck commented Jan 12, 2019

Ignore the CI build for now. The test cases are not yet written (#7).

@debck
Copy link
Owner

debck commented Jan 12, 2019 •
edited
Loading

Hey really good work 🎉
I think it would be better if initially the question would be Do u want to create directory (d) or file (f) ? (d/f)
And depending on whether its d or f the respective operation should be performed.

And always remember to mention the issue no. in the PR as : Fixes #<issue number>

Repository owner deleted a comment from TravisBuddy Jan 12, 2019
Repository owner deleted a comment from TravisBuddy Jan 12, 2019
@Layman806
Copy link
Contributor Author

Hey really good work
I think it would be better if initially the question would be Do u want to create directory (d) or file (f) ? (d/f)
And depending on whether its d or f the respective operation should be performed

Oh, got it! I'll do that. Thanks.

Repository owner deleted a comment from TravisBuddy Jan 12, 2019
Repository owner deleted a comment from TravisBuddy Jan 12, 2019
@debck debck merged commit 470507f into debck:master Jan 12, 2019
@debck
Copy link
Owner

debck commented Jan 12, 2019

@Layman806 always remember to mention the issue no. in the PR as : Fixes #<issue number>

Thanks for contributing 🎉. Hope you solve more issues.

@Layman806
Copy link
Contributor Author

@Layman806 always remember to mention the issue no. in the PR as : Fixes #<issue number>

Thanks for contributing . Hope you solve more issues.

Thanks a bunch, @debck ! 👍 XD

thesmallstar pushed a commit to thesmallstar/File-Creator-CLI that referenced this pull request Jan 17, 2019
@debck @thesmallstar
# This is a combination of 22 commits.
95bb787 
# This is the 1st commit message:

Update README.md
# This is the commit message debck#2:

Added create folder option, fixes (debck#8) (debck#13)

* Added create folder option, fixes (debck#8)

* Reverted changes to json files to try to not break build

* Better add folder option, fixes (debck#8)

# This is the commit message debck#3:

Update .travis.yml
# This is the commit message debck#4:

Update README.md
# This is the commit message debck#5:

Update app.js

# This is the commit message debck#6:

Update ifdir.js

# This is the commit message debck#7:

Update question.js

# This is the commit message debck#8:

Update ifdir.js

# This is the commit message debck#9:

Update app.js

# This is the commit message debck#10:

Update question.js

# This is the commit message debck#11:

Update app.js

# This is the commit message debck#12:

Update question.js
# This is the commit message debck#13:

Update app.js

# This is the commit message debck#14:

Create functions.js

# This is the commit message debck#15:

Update question.js

# This is the commit message debck#16:

Update ifdir.js

# This is the commit message debck#17:

Update create.js

# This is the commit message debck#18:

Update app.js

# This is the commit message debck#19:

Update create.js

# This is the commit message debck#20:

Create sub.js

# This is the commit message debck#21:

Solves debck#12(Added badges to Readme) (debck#16)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

# This is the commit message debck#22:

Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Layman806 @debck