integrate sa11y into the example #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview fo the exported examples will be rendered at |
|
axe raises an accessbility violation on the sa11y checker. https://github.com/deathbeds/nbconvert-a11y/actions/runs/7133194048 we are ignoring sa11y from the tests as it is a third party |
|
since this is configurable and works for a demo im going to merge. after this we have two examples of automated accessibility checking. having these in a reference implementation can be practical for reporting, authoring, and development. there are reasons to include them and not to include them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sa11y is an authoring focused in browser accessiblility checker that require only css/js to integrate.
the sa11y content MUST be loaded before requirejs otherwise we get "Mismatched anonymous define()" errors.