Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve last-known-good preview site #27

Merged
merged 8 commits into from
Dec 15, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Dec 15, 2023

what kind of request is this?

  • a preview site on ReadTheDocs
    • it only adds a jupyak_config.toml
  • a jupyak code change
    • it adds new features, described below

for jupyak code changes

references

code changes

  • change the name of the generated lite archive to include the branch, e.g. jupyak-16-jupyterlite.tgz
  • if a site fails to build, but a previous archive is available, download and extract it from _static/last-known-good

user-facing changes

  • failing PRs that worked at least once should see a sidebar
    • image

backwards-incompatible changes

  • if a PR was previously setting jupyter_lite_config.json#/output_archive in a gist, it will be ignored

Copy link

jupyak-badge 👈 Try it on ReadTheDocs

@bollwyvl bollwyvl changed the title Gh 26 keep last known good Preseve last-known-good build Dec 15, 2023
@bollwyvl bollwyvl changed the title Preseve last-known-good build Preserve last-known-good preview site Dec 15, 2023
@bollwyvl
Copy link
Contributor Author

Kicking tires here:

  • https://readthedocs.org/projects/jupyak/builds/22869192/
    • if that fails (boo), it will test if the legacy lite-jupyterlite.tgz gets downloaded.
    • if that passes (yay), we don't care about the legacy url,
      • and can (hopefully) fix
        • then break the build to see the feature work as intended

@bollwyvl bollwyvl marked this pull request as ready for review December 15, 2023 19:26
@bollwyvl bollwyvl merged commit 881114f into deathbeds:main Dec 15, 2023
2 checks passed
@bollwyvl bollwyvl deleted the gh-26-keep-last-known-good branch December 15, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include previous lite builds in case of recoverable failure
1 participant