Dburke/issue 1353

.fastly/config.toml

@@ -18,7 +18,7 @@ toolchain_constraint = ">= 1.21"           # Go toolchain constraint for use wit
 toolchain_constraint_tinygo = ">= 1.18"    # Go toolchain constraint for use with TinyGo.
 
 [language.rust]
-toolchain_constraint = ">= 1.78.0"
+toolchain_constraint = ">= 1.78.0, < 1.91.0" # Rust 1.91.0 produces broken WASM packages which crash when handling requests
 wasm_wasi_target = "wasm32-wasip1"
 
 [wasm-tools]

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,3 +1,11 @@
+### Change summary
+
+ <!--
+Briefly describe the changes introduced in this pull request. Include context or
+reasoning behind the changes, even if they seem minor. If relevant, link to any
+related discussions (e.g. Slack threads, tickets, documents).
+-->
+
  All Submissions:
 
 * [ ] Have you followed the guidelines in our Contributing document?
@@ -11,7 +19,6 @@
 
 ### Changes to Core Features:
 
-* [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
 * [ ] Have you written new tests for your core changes, as applicable?
 * [ ] Have you successfully run tests with your changes locally?
 
@@ -21,4 +28,4 @@
 
 ### Are there any considerations that need to be addressed for release?
 
-<!-- Any breaking changes, etc -->
+<!-- Any breaking changes, etc -->

.github/workflows/dependabot_changelog_update.yml

@@ -20,7 +20,7 @@ jobs:
           owner: ${{ github.repository_owner }}
           repositories: "cli"
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           token: ${{ steps.github-token.outputs.token }}
           repository: ${{ github.event.pull_request.head.repo.full_name }}
@@ -32,6 +32,6 @@ jobs:
           changelogPath: './CHANGELOG.md'
           entryPrefix: 'build(deps): '
       - name: Commit changelog entry
-        uses: stefanzweifel/git-auto-commit-action@v6
+        uses: stefanzweifel/git-auto-commit-action@v7
         with:
           commit_message: "docs(CHANGELOG.md): add dependency bump from dependabot"

.github/workflows/merge_to_main.yml

@@ -14,15 +14,15 @@ jobs:
     runs-on: ${{ matrix.platform }}
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: "Install Node"
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: 18
       - name: "Install Rust"
         uses: dtolnay/rust-toolchain@1.83.0 # to install tq via `make config`
       - name: Install Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: 1.24.x
       - name: "Install dependencies"
@@ -32,7 +32,7 @@ jobs:
         run: make build
         shell: bash
       - name: "Upload Build"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         with:
           name: fastly-cli-build-${{ matrix.platform }}-${{ github.sha }}
           path: fastly

.github/workflows/pr_test.yml

@@ -1,12 +1,15 @@
-on: 
+name: Test
+
+on:
   pull_request:
     types:
       - opened
       - synchronize
       - reopened
+      - labeled
+      - unlabeled
     branches:
       - main
-name: Test
 # Stop any in-flight CI jobs when a new commit is pushed.
 concurrency:
   group: ${{ github.ref_name }}
@@ -16,18 +19,18 @@ jobs:
     if: github.actor != 'dependabot[bot]'
     runs-on: ubuntu-latest
     steps:
-    - uses: dangoslen/changelog-enforcer@v3
+      - uses: dangoslen/changelog-enforcer@v3
   config:
     runs-on: ubuntu-latest
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: "Install Rust"
         uses: dtolnay/rust-toolchain@stable
       - name: "Generate static app config"
         run: make config
       - name: "Config Artifact"
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         with:
           name: config-artifact-${{ github.sha }}
           path: pkg/config/config.toml
@@ -36,26 +39,26 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: "Install Rust"
         uses: dtolnay/rust-toolchain@stable
       - name: Install Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: 1.24.x
       - name: "Install dependencies"
         run: make mod-download
         shell: bash
       - name: "Config Artifact"
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v6
         with:
           name: config-artifact-${{ github.sha }}
       - name: "Move Config"
         run: mv config.toml pkg/config/config.toml
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.1
+          version: v2.4
           only-new-issues: true
   test:
     needs: [config]
@@ -68,9 +71,9 @@ jobs:
     runs-on: ${{ matrix.platform }}
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: "Install Go"
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: ${{ matrix.go-version }}
           # IMPORTANT: Disable caching to prevent cache restore errors later.
@@ -86,11 +89,11 @@ jobs:
         run: rustup show && rustup target list --installed --toolchain stable
         shell: bash
       - name: "Install Node"
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix.node-version }}
       - name: "Config Artifact"
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v6
         with:
           name: config-artifact-${{ github.sha }}
       - name: "Move Config"
@@ -118,7 +121,43 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: Build docker images
         run: |
           for dockerFile in Dockerfile*; do docker build -f $dockerFile . ; done
+  golangci-latest:
+    name: lint-latest (informational)
+    needs: [config]
+    runs-on: ubuntu-latest
+    continue-on-error: true
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+      - name: Download config artifact
+        uses: actions/download-artifact@v6
+        with:
+          name: config-artifact-${{ github.sha }}
+          path: pkg/config
+      - name: Verify embedded config exists
+        run: |
+          test -f pkg/config/config.toml || { echo "missing pkg/config/config.toml"; ls -la pkg/config; exit 1; }
+      - name: Setup Go
+        uses: actions/setup-go@v6
+        with:
+          go-version: 1.24.x
+      - name: Run golangci-lint@latest
+        id: lint
+        uses: golangci/golangci-lint-action@v8
+        with:
+          version: latest
+          only-new-issues: true
+        continue-on-error: true
+      - name: Report lint summary
+        run: |
+          if [ "${{ steps.lint.outcome }}" == "success" ]; then
+            echo "✅ golangci-lint@latest passed." >> $GITHUB_STEP_SUMMARY
+          else
+            echo "⚠️ golangci-lint@latest failed (informational only)." >> $GITHUB_STEP_SUMMARY
+          fi

.github/workflows/publish_release.yml

@@ -9,11 +9,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: "Fetch unshallow repo"
         run: git fetch --prune --unshallow
       - name: Set up Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: 'lts/*'
           registry-url: 'https://registry.npmjs.org'

.github/workflows/tag_to_draft_release.yml

@@ -9,11 +9,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: "Fetch unshallow repo"
         run: git fetch --prune --unshallow
       - name: "Install Go"
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: '1.24.x'
       - name: "Install Rust"