remove promise chain in sendNative -- postMessage does not return anything #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During normal use of the extension, I noticed error-like output in the browser console (Cmd-Shift-J)
After poking around with the debugger and reading up on native messaging, I've concluded that postMessage does not return anything (and in particular, not a promise that can chain
then
andcatch
).Without this change, each call from
receiveNative
tosendNative
posts a message, raises a TypeError, which ends up callingsendNative
again viasendError
With this change, the errors are eliminated, and the sent message is logged.
Before
After