Add Skills Support and Command→Agent→Skill Architecture#15
Merged
Conversation
Introduce model-invoked skills that automatically enforce quality patterns without manual invocation. Skills activate based on context and provide proactive quality gates during implementation. Skills added: - pattern-check: Enforce Result types, DI, immutability, pure functions - test-design: Detect test quality issues (complex setup, difficult mocking) - code-smell: Catch fake solutions, unlabeled workarounds, magic values - research: Auto-trigger pre-implementation planning for unfamiliar features - debug: Systematic debugging with hypothesis testing and root cause analysis - input-validation: Enforce boundary validation (parse-don't-validate, SQL injection) - error-handling: Ensure Result type consistency and exception boundaries This shifts quality enforcement from reactive (code review) to proactive (during implementation), catching violations before they're committed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove /research and /debug commands in favor of skills-based approach. These workflows work better as auto-activating skills rather than manual commands: - research skill auto-triggers when unfamiliar features are requested - debug skill activates when errors occur or tests fail This reduces friction (no need to remember to invoke commands) and ensures best practices are always applied. Breaking change: /research and /debug commands removed. Users should rely on automatic skill activation instead. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update init command to: - Install skills to ~/.claude/skills/devflow/ - Clean old skills directory on reinstall - Display installed skills in output with auto-activate annotation - Update component list to include skills Installation now shows both commands (user-invoked) and skills (model-invoked) to clarify the distinction. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add skills section explaining: - What skills are and how they differ from commands - Auto-activation triggers for each skill - How skills enforce quality proactively - Updated workflows showing skill integration - Skills installation path Reorganize command list to clarify user-invoked vs model-invoked capabilities. Update examples to show skills auto-activating during development. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add comprehensive guide for developing skills: - Skill structure and YAML frontmatter requirements - When to use skills vs commands - Skill activation testing procedures - Integration with project philosophy - Examples of current skills Update architecture overview to include skills as fourth main component alongside CLI, commands, and sub-agents. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
BREAKING FIX: uninstall command now properly removes skills directory Previously, 'devflow uninstall' was NOT removing the skills directory, leaving orphaned files in ~/.claude/skills/devflow/. This occurred because we were manually managing each directory separately, making it easy to forget new additions. Refactored both init.ts and uninstall.ts to use a namespace pattern with a single source of truth for all DevFlow directories: - commands/devflow - agents/devflow - skills/devflow - scripts This ensures: - Uninstall properly removes ALL DevFlow namespaces - Adding new directories in the future requires only one line change - Impossible to forget a directory (DRY principle) - Consistent behavior between init and uninstall Updated CLI output to clearly distinguish between commands (manual) and skills (auto-activate) for better user understanding. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Restored /research and /debug as explicit commands in addition to skills. This implements a "dual-mode" pattern where research and debug exist as: 1. Commands (manual, user-invoked): /research, /debug - Explicit control when user wants deep analysis - Launches sub-agent with separate context - Full workflow with documentation tracking 2. Skills (auto, model-invoked): research skill, debug skill - Proactive assistance during implementation - Inline guidance and enforcement - Context-aware activation This gives users maximum flexibility: - Explicit control when they want it - Automatic assistance when they need it Updated init.ts to clearly show both modes in installation output with "(manual)" and "(auto)" labels for clarity. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Isolate stderr with stdio configuration - Validate git root path for injection patterns (newlines, semicolons, &&) - Ensure returned path is absolute - Prevent command injection vulnerability (HIGH-1 from code review) Addresses security concern in init.ts where execSync was called without proper input validation on the returned git root path. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Implement clean separation following DevFlow philosophy: - Commands: Orchestrate workflows (launch agents) - Agents: Execute intensive analysis (separate context) - Skills: Guide decisions (lightweight dispatchers) Changes: - Created debug agent (12k lines) for systematic debugging - Simplified /debug command: 228 → 56 lines (launches agent) - Simplified debug skill: 484 → 119 lines (auto-dispatcher) - Simplified research skill: 381 → 135 lines (auto-dispatcher) - Total skill reduction: 3026 → 2415 lines (611 lines saved) Architecture Benefits: - Main session stays clean (skills are lightweight) - Heavy analysis offloaded to agents (separate context) - Auto-activation preserves autonomy (skills dispatch agents) - Context-efficient while maximizing AI quality Skills now: 1. Detect when heavy work needed 2. Auto-launch appropriate agent 3. Summarize agent results 4. Keep main session focused This ensures comprehensive research/debugging happens in isolated context while main session remains clean and focused on implementation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Complete separation of session context from codebase analysis: **Command Changes (devlog.md):** - Before: 369 lines with Bash, Read, Grep, Glob, Write, TodoWrite, Task - After: 409 lines with Task, Write, TodoWrite only - Removed: All inline git/find/grep operations - Architecture: Session context (inline) + Project state (agent) **New Agent (project-state.md):** - 465 lines of comprehensive codebase analysis - Handles: Git history, file changes, TODO scanning, docs structure - Returns: Structured data for status documentation - Tools: Bash, Read, Grep, Glob **Workflow:** 1. Command captures session-local context (conversation, todos) 2. Command launches project-state agent (separate context) 3. Agent analyzes codebase (git, files, TODOs, docs, tech stack) 4. Command synthesizes agent data + session context 5. Command writes comprehensive status documents **Benefits:** - Main session: Zero heavy bash/grep work - Agent context: All codebase analysis isolated - Clean separation: Session vs project state - Follows orchestrator pattern: Commands launch agents **Philosophy Applied:** - Commands → Orchestrate workflows - Agents → Execute intensive analysis - Main session stays clean and focused This completes the orchestrator pattern refactoring for all major commands that were doing heavy codebase analysis inline. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Create intelligent implementation orchestrator that guides users through todo implementation with continuous interaction and quality enforcement. **Command**: /implement (507 lines) **Type**: Smart Interactive Orchestrator **Tools**: TodoWrite, Read, Write, Edit, AskUserQuestion, Bash, Grep, Glob **Workflow**: 1. Load current todos from TodoWrite 2. Interactive triage (remove, defer, prioritize) 3. For each todo in priority: - Analyze complexity (Simple/Medium/Complex) - Seek clarification only when needed (AskUserQuestion) - Share implementation plan - Implement following existing patterns - Skills auto-validate (pattern-check, test-design, etc.) - Mark complete, move to next 4. Comprehensive session summary **Key Features**: - **Smart Triage**: User controls what to implement vs defer - **One Question at a Time**: Only asks when genuinely unclear - **Pattern-Driven**: Finds and follows existing code patterns - **Quality by Default**: Existing skills enforce patterns automatically - **Transparent Progress**: Shows plan before implementing - **Continuous Interaction**: Can pause for decisions/clarification **Philosophy**: Pair programming with AI - User decides priorities and provides clarification - AI implements with user guidance - Quality enforced through existing skills - No need for separate implementation agent **Usage**: User: /implement → Triage todos → Implement iteratively with guidance → Summary and recommendations This completes the implementation workflow: /plan-next-steps → /implement → /code-review → /commit 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Addresses all 4 critical documentation issues identified in comprehensive code review (.docs/audits/feat-add-skills-support/comprehensive-review.md): 1. Add missing commands to table: - /implement - Smart interactive implementation orchestrator - /debug - Systematic debugging workflow - /research - Pre-implementation research and approach analysis 2. Add auto-activation warning: - Clear statement that skills cannot be manually invoked - Prevents user confusion about skill invocation 3. Document dual-mode pattern: - Explains research/debug exist as both skill (auto) and command (manual) - Clarifies when to use each mode - Provides best of both worlds: automatic assistance + manual control 4. Skills path verification: - Confirmed already documented in CLAUDE.md:425 - No changes needed Impact: Resolves all blocking documentation issues from code review. Estimated time saved in user confusion: significant. Related: PR #15, comprehensive review 2025-10-21_2111 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Release 0.4.0 with 12 commits since v0.3.3 - Skills infrastructure with 7 auto-activating skills - /implement command for guided implementation - Command→Agent→Skill dual-mode architecture - Security and bug fixes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DevFlow Skills Support & Architectural Improvements
This PR introduces comprehensive skills support and implements a clean command→agent→skill architecture pattern for DevFlow.
🎯 Summary
Skills Infrastructure (7 Auto-Activate Skills)
Pattern Enforcers:
pattern-check- Validates Result types, DI, immutability, pure functionstest-design- Ensures test quality and integration focuscode-smell- Detects fake solutions, hardcoded data, unlabeled workaroundsWorkflow Guides:
research- Auto-launches research agent for unfamiliar features (lightweight dispatcher)debug- Auto-launches debug agent for systematic debugging (lightweight dispatcher)Safety Validators:
input-validation- Boundary validation, parse-don't-validate enforcementerror-handling- Result type consistency, exception boundary checksArchitecture Pattern: Commands → Agents → Skills
Implemented clean separation:
New Agents
debug- Systematic debugging with hypothesis testing (12k lines)project-state- Codebase analysis for status reporting (465 lines)New Commands
/implement- Smart interactive implementation orchestrator (507 lines)Refactored Commands
/debug- Now launches debug agent (228 → 56 lines)/devlog- Now launches project-state agent (369 → 409 lines, but zero bash/grep)Skills Refactored
research- Lightweight dispatcher (381 → 135 lines)debug- Lightweight dispatcher (484 → 119 lines)📊 Changes
Added
src/claude/skills/devflow/debug.md,project-state.mdimplement.mdinit.ts)Modified
/debugcommand to orchestrator pattern/devlogcommand to orchestrator patternRemoved
/debugand/devlogcommands🏗️ Architecture Benefits
Context Efficiency:
Separation of Concerns:
Quality by Default:
🔄 Complete Workflow
User workflow now fully integrated:
🔧 Implementation Details
Skills Auto-Activation
Dual-Mode Pattern
Research and debug exist as:
/research,/debug- User explicitly requestsThis gives maximum flexibility and autonomy.
📝 Testing
npm run build)🚀 Impact
For Users:
For Developers:
📚 Documentation
🤖 Generated with Claude Code