fix: remove auto-publish, make releases explicit#57
Merged
Conversation
release.yml triggered on GitHub release publish events but always failed at `npm test` (which exits 1 by design). ci.yml already handles publishing on push to main. Removes the broken duplicate.
Review Summary by QodoRemove dead release.yml workflow
WalkthroughsDescription• Removes broken .github/workflows/release.yml workflow • Workflow triggered on GitHub releases but always failed at npm test • ci.yml already handles publishing on push to main • Resolves duplicate and non-functional release mechanism Diagramflowchart LR
A["release.yml<br/>GitHub Release Trigger"] -->|"Deleted"| B["Removed<br/>Broken Workflow"]
C["ci.yml<br/>Push to Main"] -->|"Remains Active"| D["Sole Publishing<br/>Mechanism"]
File Changes1. .github/workflows/release.yml
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
- Remove auto-publish release job from ci.yml - Add new release.yml triggered manually from GitHub Actions UI - Merging a version bump to main no longer auto-publishes - Update CLAUDE.md release process docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/release.yml(triggered on GitHub release events, always failed atnpm test)ci.yml— merging to main no longer triggers npm publishrelease.ymlwithworkflow_dispatchtrigger — releases are now explicitly requested from the GitHub Actions UICloses #50
What changed
ci.ymlauto-published on merge to main when version changedci.ymlonly runs testsrelease.ymltriggered on GitHub release eventsrelease.ymltriggered manually via workflow_dispatchTest plan
release.ymlappears in Actions tab with "Run workflow" button