Skip to content

Commit 1c6d3df

Browse files
authored
Set ensembler log level to WARNING from INFO (caraml-dev#409)
* modify ensembler log level to warning * modify ensembler log level to warning * fetch log level from environment variables - to allow debuggings * set log level to warning as env variable * modify ensembler log level enum
1 parent 8cb11ef commit 1c6d3df

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

engines/pyfunc-ensembler-service/app.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,4 @@ RUN if [ "${MLFLOW_ARTIFACT_STORAGE_TYPE}" = "gcs" ]; then \
5252
ENV FOLDER_NAME=$FOLDER_NAME
5353
SHELL ["/bin/bash", "-c"]
5454
ENTRYPOINT . activate ${CONDA_ENV_NAME} && \
55-
python -m pyfunc_ensembler_runner --mlflow_ensembler_dir ./${FOLDER_NAME} -l INFO
55+
python -m pyfunc_ensembler_runner --mlflow_ensembler_dir ./${FOLDER_NAME}

engines/pyfunc-ensembler-service/pyfunc_ensembler_runner/__main__.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import argparse
22
import logging
33
import traceback
4+
import os
45

56
import tornado.ioloop
67

@@ -22,20 +23,12 @@
2223
help="Dry run pyfunc ensembler by loading the specified ensembler "
2324
"in --mlflow_ensembler_dir without starting webserver",
2425
)
25-
parser.add_argument(
26-
"-l",
27-
"--log-level",
28-
dest="log_level",
29-
choices=["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"],
30-
help="Set the logging level",
31-
default=logging.DEBUG,
32-
)
3326

3427
args, _ = parser.parse_known_args()
35-
28+
log_level = os.getenv("LOG_LEVEL", logging.WARNING)
3629

3730
if __name__ == "__main__":
38-
logging.basicConfig(level=args.log_level)
31+
logging.basicConfig(level=log_level)
3932
logging.info(
4033
"Called with arguments:\n%s\n",
4134
"\n".join([f"{k}: {v}" for k, v in vars(args).items()]),

engines/pyfunc-ensembler-service/tests/test_ensembler_runner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"simple_ensembler_uri",
2828
dummy_short_request,
2929
{"Key": "Value"},
30-
{"headers": {"Key": "Value"}, "enricher_response" : None},
30+
{"headers": {"Key": "Value"}, "enricher_response": None},
3131
),
3232
],
3333
)

0 commit comments

Comments
 (0)