Skip to content

Conversation

@vinoth-gojek
Copy link
Contributor

@vinoth-gojek vinoth-gojek commented Jul 16, 2025

The default turing ensembler log level is set to INFO but this spams with too many logs thus causing memory consumption in downstream logging platform.

The goal of this very simple MR is to modify this log level to WARNING from INFO - python logging loglevels

Also there is an added capability for DS folks to change the ensembler log levels to INFO using env

@vinoth-gojek vinoth-gojek changed the title [WIP] Set ensembler log level to WARNING from INFO Set ensembler log level to WARNING from INFO Jul 16, 2025
@vinoth-gojek vinoth-gojek requested a review from anantadwi13 July 17, 2025 08:45
Copy link
Contributor

@anantadwi13 anantadwi13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for fixing this!

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.38%. Comparing base (34c8f32) to head (5a35e6c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files          26       26           
  Lines        2101     2101           
=======================================
  Hits         2025     2025           
  Misses         76       76           
Flag Coverage Δ
sdk-test-3.10 96.38% <ø> (ø)
sdk-test-3.11 96.38% <ø> (ø)
sdk-test-3.12 96.38% <ø> (ø)
sdk-test-3.9 96.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@deadlycoconuts deadlycoconuts force-pushed the modify_ensembler_log_level branch from 5a35e6c to d90f516 Compare July 31, 2025 10:05
@deadlycoconuts deadlycoconuts force-pushed the modify_ensembler_log_level branch 3 times, most recently from 79418d5 to 0deb2a5 Compare August 1, 2025 10:18
@deadlycoconuts deadlycoconuts merged commit 1c6d3df into main Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants