Open
Conversation
Covers plugin page load, operation selection, report tabs (stats, agents, steps, tactics, facts), PDF download, JSON export, D3 graph rendering, graph settings modal, and error states. Tests run against a full Caldera instance via CALDERA_URL env var.
…e bugs - Extract mockDebriefRoutes() helper to eliminate ~400 lines of copy-pasted route mocking across 15 tests - Replace all waitForTimeout() calls with deterministic waits (waitForResponse, waitFor on locators) - Replace networkidle with domcontentloaded + explicit heading wait - Remove unmocked live API test that would fail without running server - Fix playback button count comment (6 buttons including legend toggle) - Use baseURL from playwright config instead of duplicating CALDERA_URL - Fix file handle leak in c_story.py adjust_icon_svgs - Add viewBox null check in c_story.py - Fix stale op_id bug in debrief_svc.py build_steps_d3
In CI (process.env.CI), CALDERA_USER and CALDERA_PASS must be set explicitly via env vars — config throws if missing. Locally, defaults to admin/admin for developer convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of mitre/debrief PR mitre#80 for Copilot review