Skip to content

Conversation

@ddzzj
Copy link
Owner

@ddzzj ddzzj commented Nov 29, 2023

This PR was automatically created by Snyk using the credentials of a real user.


Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.

Changes included in this PR

  • images/benchmarks/nginx/Dockerfile

We recommend upgrading to nginx:1.25.3, as this image has only 76 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@guardrails
Copy link

guardrails bot commented Nov 29, 2023

⚠️ We detected 1 security issue in this pull request:

Insecure Access Control (1)
Severity Details Docs
High Title: Missing User Instruction
📚

More info on how to fix Insecure Access Control in Dockerfile.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

@@ -1,4 +1,4 @@
FROM nginx:1.15.10
FROM nginx:1.25.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Healthcheck instructions have not been added to container images
    Resource: /images/benchmarks/nginx/Dockerfile. | Checkov ID: CKV_DOCKER_2

Description

We recommend that you add the HEALTHCHECK instruction to your Docker container images to ensure that health checks are executed against running containers.
An important security control is that of availability.
Adding the HEALTHCHECK instruction to your container image ensures that the Docker engine periodically checks the running container instances against that instruction to ensure that containers are still operational.
Based on the results of the health check, the Docker engine could terminate containers which are not responding correctly, and instantiate new ones.

@@ -1,4 +1,4 @@
FROM nginx:1.15.10
FROM nginx:1.25.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  A user for the container has not been created
    Resource: /images/benchmarks/nginx/Dockerfile. | Checkov ID: CKV_DOCKER_3

Description

Containers should run as a non-root user.
It is good practice to run the container as a non-root user, where possible.
This can be done either via the USER directive in the Dockerfile or through gosu or similar where used as part of the CMD or ENTRYPOINT directives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants