Open
Conversation
added 5 commits
December 21, 2017 08:44
For a 12-hour clock, the hour should show as a single digit for hours 1 - 9, not as two digits.
Added indicator if quiet time is enabled.
This reverts commit 8fbdf4c. That commit was made on the wrong branch.
The removal of . was not intentional. It should remain. However, escaping . in a character class is not necessary, so I didn't restore the double \ in front of it.
If both power saving options are off, the watchface will crash when unloading, because it tries to unsubscribe from the health service events, but it never subscribed in the first place! Also fixed unsubscribing from the tick timer service, since the wrong parameter was passed to unsubscribe when unloading the window, and it wasn't protected by a NULL pointer check (it shouldn't be NULL, but just in case, it's better to check).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If both power saving options are off, the watchface will crash when unloading,
because it tries to unsubscribe from the health service events, but it never
subscribed in the first place!
Also fixed unsubscribing from the tick timer service, since the wrong parameter was passed to unsubscribe when unloading the window, and it wasn't protected by a NULL pointer check (it shouldn't be NULL, but just in case, it's better to check).