Skip to content

TODOs are converted to DTODOs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion channeld/full_channel.c
Original file line number Diff line number Diff line change
Expand Up @@ -1349,7 +1349,7 @@ bool channel_sending_commit(struct channel *channel,
SENT_REMOVE_HTLC };
status_debug("Trying commit");

// TODO: Should this method check for splices?
// DTODO: Should this method check for splices?
/* A sending node:
* - MUST NOT send a `commitment_signed` message that does not include any
* updates, or add or remove splices.
Expand Down
4 changes: 2 additions & 2 deletions hsmd/libhsmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ bool hsmd_check_client_capabilities(struct hsmd_client *client,
return (client->capabilities & HSM_CAP_SIGN_CLOSING_TX) != 0;

case WIRE_HSMD_SIGN_SPLICE_TX:
return true; //TODO: check capabilities
return true; //DTODO: check capabilities

case WIRE_HSMD_SIGN_OPTION_WILL_FUND_OFFER:
return (client->capabilities & HSM_CAP_SIGN_WILL_FUND_OFFER) != 0;
Expand Down Expand Up @@ -1068,7 +1068,7 @@ static u8 *handle_sign_mutual_close_tx(struct hsmd_client *c, const u8 *msg_in)
}

/* This is used by channeld to sign the final splice tx. */
//TODO: Merge this into the close_tx
//DTODO: Merge this into the close_tx
static u8 *handle_sign_splice_tx(struct hsmd_client *c, const u8 *msg_in)
{
struct secret channel_seed;
Expand Down
2 changes: 1 addition & 1 deletion lightningd/Tasks.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ DONE * Make commit_sigs work after splice confirms
* validate point of no return when lightningd
* At the last step before signing the splice, validate all the commit sigs etc thoroughly before.
*
* Change all TODOs in my code to DTODOs
DONE * Change all TODOs in my code to DTODOs
* Add helpful log messages in places to be able to see what's going on
* Figure out why we can't pay invoices after splice_init
* Change splice RPC to use channel_id instead of peer_id
Expand Down
2 changes: 1 addition & 1 deletion lightningd/dual_open_control.c
Original file line number Diff line number Diff line change
Expand Up @@ -2760,7 +2760,7 @@ static void handle_psbt_changed(struct subd *dualopend,
abort();
}

// TODO: splitting into a one time event
// DTODO: splitting into a one time event
// and multiple sig updates over time
static void handle_commit_received(struct subd *dualopend,
struct channel *channel,
Expand Down
4 changes: 2 additions & 2 deletions lightningd/peer_control.c
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,7 @@ static enum watch_result funding_depth_cb(struct lightningd *ld,
return DELETE_WATCH;
}

// TODO: Handle the case where we get here with an inflight splice
// DTODO: Handle the case where we get here with an inflight splice
// 1) Make the inflight *not* replace the existing tx until 6 confs
// 2) Current code just sets the last_sig to 0x0. Need to set that to the right thing
// 3) Make it go!
Expand Down Expand Up @@ -1357,7 +1357,7 @@ static enum watch_result funding_depth_cb(struct lightningd *ld,
else if (false && channel->state != CHANNELD_AWAITING_SPLICE
&& !short_channel_id_eq(channel->scid, &scid)) {

/* TODO: This is firing after 6 depth splice */
/* DTODO: This is firing after 6 depth splice */

/* During reorgs:
* This normally restarts channeld, initialized with updated scid
Expand Down
2 changes: 1 addition & 1 deletion openingd/dualopend.c
Original file line number Diff line number Diff line change
Expand Up @@ -2501,7 +2501,7 @@ static u8 *opener_commits(struct state *state,
}


// TODO: Copy the below procedure for splicing
// DTODO: Copy the below procedure for splicing
// We probably need to do this in response to commitment_signed message
// and / or in the revoke_and_ack code

Expand Down