Fix crash when unloading the library #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static destructor order is unsepcified which leads to Memory::~Memory() running before libEnd(). Moving cleanup code to automatically generated destructors using stl and std::unique_ptr memory managemt avoids issues with unspecified static destructor call order. Signed-off-by: Pauli <suokkos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed dds was causing crash in exit because libEnd was called after memory::~memory(). Static destructor are executed in unspecified order. To avoid order issues I decided to make changes which moves all memory cleanup code to automatically generated destructors using stl and std::unique_ptr memory management.
I noticed there is pull request #90. But it seems to have issues still so I decided to provide alternative attempt at fixing same issue.