fix connamara#571: unexpected null from GetProxy

Thanks to mkoca & mcmillab in the Github issue. connamara#571 (comment)
ddrdoubled · Feb 28, 2020 · a1cd714 · a1cd714
1 parent 653abba
commit a1cd714
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/QuickFIXn/Transport/StreamFactory.cs b/QuickFIXn/Transport/StreamFactory.cs
@@ -37,6 +37,9 @@ private static Socket CreateTunnelThruProxy(string destIP, int destPort)
             }
 
             Uri proxyUri = webProxy.GetProxy(destUri);
+            if (proxyUri == null)
+                return null;
+
             IPAddress[] proxyEntry = Dns.GetHostAddresses(proxyUri.Host);
             int iPort = proxyUri.Port;
             IPAddress address = proxyEntry.First(a => a.AddressFamily == AddressFamily.InterNetwork);

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -10,6 +10,7 @@ What's New
 
 ### NEXT VERSION:
 * (patch) #505 - Fix ObjectDisposedException when SocketInitiator is stopped before connection attempt fails (musashibg)
+* (patch) #571 - StreamFactory fix: unexpected null from GetProxy (mkoca & mcmillab)
 
 ### v1.9.0:
 * (minor) #469 - Add support for NET Standard 2.0 (jhickson)