Use `localhost` not `solr` as Host

[gitressa]

Is there an existing issue for this?

• I have searched the existing issues

Is your feature request related to a problem?

Problem

The value for Host is solr, but Solr on a production server normally uses the value localhost. This means that the user needs to change Host to solr to work with DDEV, and then on the server, they need to add something like this:`

$config['search_api.server.solr_server']['backend_config']['connector_config']['host'] = 'localhost';

Describe your solution

Use localhost as Host for Solr.

Describe alternatives

If it's not possible to set Host to localhost in DDEV, maybe we could automatically add an override in settings.ddev.php when the DDEV Solr add-on is installed, something like this?

$config['search_api.server.solr_server']['backend_config']['connector_config']['host'] = 'solr';

Additional context

See also Drupal issue Make Solr Host more likely to work with default settings, where I suggested an update in Search API Solr.

[rfay]

On a production server, solr would normally be on a different host, not localhost.

localhost means "this server", and it's not normal to run a complex Java-based daemon on the web server.

It's not desirable to run solr in the ddev-webserver either, although it's perhaps possible

[rfay]

Happy to continue the conversation, of course.

[rfay]

I think it would be possible to add add a settings.ddev-solr.php like the redis add-on does.

[gitressa]

Thanks @rfay, that sounds great! Perhaps the issue can be reopened if this might be possible?

Please, see also Make Solr Host more likely to work with default settings where @mkalkbrenner recommends using localhost as the default.

[rfay]

localhost doesn't really work in the vast majority of situations, as explained.

It's not necessary to reopen this, if you want to experiment with a PR, it's welcome.

[gitressa]

@rfay You and @mkalkbrenner are both open to adding a solution, which is great -- I am just not sure which one is best ...

I think the ideal method to find a solution, is if you and @mkalkbrenner discussed it, either in this issue or Make Solr Host more likely to work with default settings, where @mkalkbrenner posted this:

The default of the module should not target a specific development environment. (even if I use ddev)
I will keep the the default as it is.

By I will accept a patch that changes it dynamically if a ddev environment is detected.

[rfay]

Solr on a production server normally uses the value localhost

This just isn't true. It might be true for you, but most systems in production use an external host for solr. It doesn't make sense for performance to run all services on the same host (so webserver, db server, and solr on same machine). This isn't common in production, and can't be done where there are significant performance requirements.