Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Exclude files from releases/tarballs
tests/ export-ignore
.github/ export-ignore
.gitattributes export-ignore
8 changes: 6 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
## The Issue

- #<issue number>
- Fixes #REPLACE_ME_WITH_RELATED_ISSUE_NUMBER

<!-- Provide a brief description of the issue. -->

## How This PR Solves The Issue

<!-- Describe the key change(s) in this PR that address the issue above. -->

## Manual Testing Instructions

<!-- If this PR changes logic, consider adding additional steps or context to the instructions below. -->

```bash
ddev add-on get https://github.com/<user>/<repo>/tarball/<branch>
ddev add-on get https://github.com/ddev/ddev-selenium-standalone-chrome/tarball/refs/pull/REPLACE_ME_WITH_THIS_PR_NUMBER/head
ddev restart
```

Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
name: tests
on:
pull_request:
paths-ignore:
- "**.md"
push:
branches: [ main ]
paths-ignore:
- "**.md"

schedule:
- cron: '25 08 * * *'
- cron: '25 08 * * *'

workflow_dispatch:
inputs:
Expand All @@ -19,9 +23,8 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

# This is required for "gautamkrishnar/keepalive-workflow", see "ddev/github-action-add-on-test"
permissions:
actions: write
contents: read

jobs:
tests:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

## Overview

Makes it easy to run Functional, FunctionalJavascript, and Nightwatch tests in DDEV.
Makes it easy to run Functional, FunctionalJavascript, and Nightwatch tests in DDEV.

This service can be used with any project type. The examples below are Drupal-specific. Contributions for docs and tests that show this service working with other project types are appreciated.

Expand Down Expand Up @@ -98,7 +98,7 @@ If you use Behat as a test running, adjust your `behat.yml`

## Contribute

- Anyone is welcome to submit a PR to this repo. See README.md at https://github.com/ddev/ddev-addon-template, the parent of this repo.
- Anyone is welcome to submit a PR to this repo. See [DDEV Add-on Maintenance Guide](https://ddev.com/blog/ddev-add-on-maintenance-guide/).

## Credits

Expand Down
5 changes: 1 addition & 4 deletions install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,16 @@ project_files:
- docker-compose.selenium-chrome.yaml
- config.selenium-standalone-chrome.yaml

ddev_version_constraint: '>= v1.24.3'
ddev_version_constraint: '>= v1.24.10'

post_install_actions:
- |
#ddev-nodisplay
#ddev-description:Checking docker-compose.selenium-chrome_extras.yaml for changes
if [ -f docker-compose.selenium-chrome_extras.yaml ] && ! grep -q '#ddev-generated' docker-compose.selenium-chrome_extras.yaml; then
echo "Existing docker-compose.selenium-chrome_extras.yaml does not have #ddev-generated, so can't be updated"
exit 2
fi
- |
#ddev-nodisplay
#ddev-description:Adding all hostnames to the selenium-chrome container to make them available
cat <<-END >docker-compose.selenium-chrome_extras.yaml
#ddev-generated
Expand All @@ -30,7 +28,6 @@ post_install_actions:

removal_actions:
- |
#ddev-nodisplay
#ddev-description:Remove docker-compose.selenium-chrome_extras.yaml file
if [ -f docker-compose.selenium-chrome_extras.yaml ]; then
if grep -q '#ddev-generated' docker-compose.selenium-chrome_extras.yaml; then
Expand Down