feat(*): support for Redis password #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasadev
force-pushed
the
20250428_stasadev_redis_password
branch
from
27aed7d to
cf405b0
Compare
|
Thank you! (LGTM) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
README.md explains how to set
REDIS_PASSWORDforredis-commander, and it can be automated.I recently updated ddev-redis and now it supports both auth/no auth options.
How This PR Solves The Issue
.ddev/docker-compose.redis-commander_password.yamlfile.Manual Testing Instructions
ddev dotenv set .ddev/.env.redis --redis-optimized=true ddev add-on get ddev/ddev-redis ddev add-on get https://github.com/ddev/ddev-redis-commander/tarball/20250428_stasadev_redis_password cat .ddev/docker-compose.redis-commander_password.yaml ddev restart ddev redis-commanderAutomated Testing Overview
Release/Deployment Notes