Skip to content

fix: correctly load Adminer plugins, fixes #41 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented May 1, 2025

The Issue

We override the original index.php, which loads plugins.

Before (tables-filter is not loaded, unable to filter by table):

image

How This PR Solves The Issue

Uses ddev-adminer.php instead of index.php for PHP web server entrypoint, which allows to use the original index.php without modifications.

Manual Testing Instructions

ddev add-on get https://github.com/ddev/ddev-adminer/tarball/20250501_stasadev_plugins
ddev restart
ddev adminer

After (tables-filter is loaded, input is available):

image

Automated Testing Overview

Release/Deployment Notes

@stasadev stasadev merged commit 6e1f2e7 into main May 1, 2025
2 checks passed
@stasadev stasadev deleted the 20250501_stasadev_plugins branch May 1, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant