Skip to content

Conversation

@RaulMurillo
Copy link
Contributor

@RaulMurillo RaulMurillo commented Mar 4, 2021

All Submissions

  • Is the code you are submitting your own work?
  • Have you followed the contributing guidelines?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Model Submissions

  • Is the code you are submitting your own work?
  • Did you properly attribute the authors of any code you referenced?
  • Did you write unit tests for your new model?
  • Does your submission pass the unit tests?
  • Did you write documentation for your new model?
  • Have you formatted your code using the black deaults?

Changes to Existing Models

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

This closes #61, closes #63

@RaulMurillo
Copy link
Contributor Author

Also added a commit to close #63

@ddbourgin
Copy link
Owner

Looks good to me! Thanks so much for catching + fixing this @RaulMurillo

@ddbourgin ddbourgin merged commit 741954b into ddbourgin:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in initializers init_from_dict() Bug in transfer learning

2 participants