Updating zk quorum tests #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaboka
suggested changes
Jun 7, 2017
| @@ -13,6 +13,9 @@ const ( | |||
| statusWarning | |||
| statusFailure | |||
| statusUnknown | |||
|
|
|||
| // exhibitor admin router port | |||
| exhibitorPort = 8181 | |||
There was a problem hiding this comment.
maybe we should make it configurable from CLI and set default value to 8181?
There was a problem hiding this comment.
Yup we will move all these constants to the runner once #9 gets merged
| Name: name, | ||
| } | ||
| check := &ZkQuorumCheck{Name: name} | ||
| check.urlFunc = check.getURL |
There was a problem hiding this comment.
hm, what are you trying to do here?
There was a problem hiding this comment.
This is what we did for being able to test the json parsing with a random url, if you look at the httptest we needed this. more discussion #5
mnaboka
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating zk quorum check to include tests, also fixed bugs that the tests caught