This repository was archived by the owner on Jun 5, 2020. It is now read-only.
update fs.{read,write}File{,Sync} decls #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current (0.10.31) node, these functions take an options object as their second parameter, not a string. I'm not sure when this was changed, although I think it happened many versions ago. http://nodejs.org/api/fs.html#fs_fs_readfile_filename_options_callback http://nodejs.org/api/fs.html#fs_fs_readfilesync_filename_options http://nodejs.org/api/fs.html#fs_fs_writefile_filename_data_options_callback http://nodejs.org/api/fs.html#fs_fs_writefilesync_filename_data_options The string form has been left as an alternative for users who are using old versions of node.
dcodeIO
added a commit
that referenced
this pull request
Aug 23, 2014
update fs.{read,write}File{,Sync} decls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current (0.10.31) node, these functions take an options object as
their second parameter, not a string. I'm not sure when this was
changed, although I think it happened many versions ago.
http://nodejs.org/api/fs.html#fs_fs_readfile_filename_options_callback
http://nodejs.org/api/fs.html#fs_fs_readfilesync_filename_options
http://nodejs.org/api/fs.html#fs_fs_writefile_filename_data_options_callback
http://nodejs.org/api/fs.html#fs_fs_writefilesync_filename_data_options
The string form has been left as an alternative for users who are using
old versions of node.
npm test has been run on this commit.