DCO check stays as `expected` #211

frouioui · 2024-06-03T22:51:02Z

Although the DCO app is installed in the org/user and on the repository, the check is no longer running for Pull Requests, the check stays as expected. This worked fine about an hour ago, and suddenly stopped working.

Is anyone experiencing this too?

EDIT: for those blocked by this issue @wagoodman proposed a nice solution (anchore/syft#2926)

The text was updated successfully, but these errors were encountered:

zkoppert · 2024-06-03T23:37:42Z

Yes, others experiencing this as well. It is a hosting side issue and I'm looking at it now.

Update: This may not be resolved this week due to folks being out of office. I'll post updates here as I've got them.

frouioui · 2024-06-03T23:51:41Z

Thanks for the update @zkoppert.

JeyJeyGao · 2024-06-04T02:57:35Z

We are also afacted: notaryproject/notation#952.
Our release process is blocked.

## Which problem is this PR solving? - Several PRs are stuck with DCO check pending. Apparently there's an ongoing issue with the DCO app: dcoapp/app#211 ## Description of the changes - Add an alternative DCO check into the lint workflow using https://github.com/christophebedard/dco-check ## How was this change tested? Ran the script manually: ```shell $ python3 scripts/dco_check.py -b main Detected: git (default) Checking commits: 5863430..7a5e58b All good! ``` With an unsigned commit: ```shell $ gca -m bad [manual-dco-check 7da95684] bad 1 file changed, 1 insertion(+) $ python3 scripts/dco_check.py -b main Detected: git (default) Checking commits: 5863430..7da95684408ebd3f32692e9444940bdf0e04348d Missing sign-off(s): 7da95684408ebd3f32692e9444940bdf0e04348d no sign-off found ``` --------- Signed-off-by: Yuri Shkuro <github@ysh.us>

mihaimaruseac · 2024-06-05T16:43:18Z

Thank you @zkoppert for looking at this.

I tried the close/open suggestion in sigstore/model-transparency#195 but it doesn't seem to work. Will try pushing a new commit to see if that changes things.

zkoppert · 2024-06-05T16:44:25Z

Thank you for mentioning that. The above were my best guesses. :)

See dcoapp/app#211 (comment) Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

mihaimaruseac · 2024-06-05T16:46:35Z

Pushing an empty commit on sigstore/model-transparency#190 has worked.

Thank you.

) * Migrate `serialize_v0` to new API. This is the middle layer of the API design work (#172). We add a manifest abstract class to represent various manifests (#111 #112) and also ways to serialize a model directory into manifests and ways to verify the manifests. For now, this only does what was formerly known as `serialize_v0`. The v1 and the manifest versions will come soon. Note: This has a lot of inspiration from #112, but makes the API work with all the usecases we need to consider right now. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com> * Clarify some comments Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com> * Encode name with base64 Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com> * Add another test case Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com> * Empty commit to retrigger DCO check. See dcoapp/app#211 (comment) Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com> --------- Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

rbarkerSL · 2024-06-05T17:27:37Z

I've been able to progress PRs waiting on DCO again in the last 30 minutes or so. 👍

mynameistechno · 2024-06-05T21:06:30Z

Thanks @zkoppert !

See dcoapp/app#211 (comment) Signed-off-by: Danny Eiselt <eiselt@b1-systems.de>

see dcoapp/app#211 (comment) Signed-off-by: Danny Eiselt <eiselt@b1-systems.de>

* changed: v1alpha7 to v1beta1 Signed-off-by: Danny Eiselt <eiselt@b1-systems.de> * added: oidc to new version + v1beta1 Signed-off-by: Danny Eiselt <eiselt@b1-systems.de> * chore(node-images): update to 1.27.14 Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * chore(node-images): update to 1.27.14 Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * fix: change cluster stack name Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * Dummy commit to trigger DCO See dcoapp/app#211 (comment) Signed-off-by: Danny Eiselt <eiselt@b1-systems.de> * Dummy commit to retrigger DCO see dcoapp/app#211 (comment) Signed-off-by: Danny Eiselt <eiselt@b1-systems.de> --------- Signed-off-by: Danny Eiselt <eiselt@b1-systems.de> Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Co-authored-by: Malte Münch <muench@b1-systems.de>

frouioui · 2024-06-10T14:46:31Z

Thanks a lot 🙇🏻

prudhvigodithi mentioned this issue Jun 3, 2024

Update gradle config for develocity rebranding opensearch-project/OpenSearch#13942

Merged

9 tasks

prudhvigodithi mentioned this issue Jun 4, 2024

[Backport 2.x] Bump actions/checkout from 3 to 4 opensearch-project/OpenSearch#13956

Merged

yurishkuro mentioned this issue Jun 4, 2024

Add manual DCO check using Python script dco-check jaegertracing/jaeger#5528

Merged

wuhuizuo mentioned this issue Jun 4, 2024

chore: add prow OWNERS files for critial configuration files tikv/tikv#17071

Merged

2 tasks

This was referenced Jun 4, 2024

ci: workaround for centos stream 8 being EOLed opencontainers/runc#4304

Merged

Correct typos in comments in the cli/ folder docker/cli#5109

Merged

This was referenced Jun 4, 2024

chore: Remove unused file oras-project/oras#1395

Merged

chore: Remove deprecated Print method oras-project/oras#1398

Merged

This was referenced Jun 4, 2024

[kube-prometheus-stack] Update Grafana chart to 8.0.x prometheus-community/helm-charts#4586

Merged

Fix omission of RemoteFX Graphics metrics prometheus-community/windows_exporter#1511

Merged

bjhargrave mentioned this issue Jun 4, 2024

Bump rojopolis/spellcheck-github-actions from 0.36.0 to 0.37.0 instructlab/.github#38

Merged

khanhtc1202 mentioned this issue Jun 4, 2024

Google Analytics 4 (GA4): configure CNCF site ID pipe-cd/pipecd#4940

Merged

B-Step62 mentioned this issue Jun 4, 2024

Fix test_trace_ignore_exception_from_tracing_logic test mlflow/mlflow#12233

Merged

39 tasks

jedevc mentioned this issue Jun 4, 2024

chore(python): throw error if session exits unexpectedly dagger/dagger#7473

Merged

paulphys mentioned this issue Jun 4, 2024

kustomization readiness checks SovereignCloudStack/moin-cluster-config#19

Merged

This was referenced Jun 4, 2024

chore(rotate): instructions touchups cdk8s-team/cdk8s-plus#4259

Merged

chore(schema): k8s 1.30.0 cdk8s-team/cdk8s#1985

Merged

navin772 mentioned this issue Jun 4, 2024

fix(docs): Update KubeArmor VM/Bare-metal docs according to new conventions kubearmor/KubeArmor#1777

Merged

1 task

This was referenced Jun 4, 2024

release 0.8.5 hyperledger/besu-native#171

Merged

Update besu-native to 0.8.5 hyperledger/besu#7172

Merged

nathan-weinberg mentioned this issue Jun 4, 2024

refactor: remove unnecessary tmp var safe_tensors instructlab/instructlab#1257

Merged

mgovers mentioned this issue Jun 4, 2024

[FEATURE] basic validation checks for tap regulator PowerGridModel/power-grid-model#620

Merged

simonpasquier mentioned this issue Jun 4, 2024

chore: cut v0.9.0 prometheus-community/prom-label-proxy#221

Merged

leseb mentioned this issue Jun 4, 2024

introduce a release note for release instructlab/instructlab#1231

Merged

kommendorkapten mentioned this issue Jun 4, 2024

Bump github.com/google/certificate-transparency-go from 1.1.8 to 1.2.1 sigstore/sigstore-go#201

Merged

nathan-weinberg mentioned this issue Jun 4, 2024

fix: inaccurate makefile help message instructlab/instructlab#1251

Merged

mihaimaruseac mentioned this issue Jun 5, 2024

Migrate serialize_v0 to new API (as part of serialization layer) sigstore/model-transparency#190

Merged

mihaimaruseac added a commit to mihaimaruseac/model-transparency that referenced this issue Jun 5, 2024

Empty commit to retrigger DCO check.

d1c7261

See dcoapp/app#211 (comment) Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

agilgur5 mentioned this issue Jun 5, 2024

fix(build): uname handling for mac M1 arch. Fixes #13112 argoproj/argo-workflows#13113

Merged

ishitasequeira mentioned this issue Jun 5, 2024

chore: enable bool-compare rule from testifylint linter argoproj/argo-cd#18414

Merged

jmeridth mentioned this issue Jun 5, 2024

fix(argo-cd): remove secretName for server and applicationSet Certificates argoproj/argo-helm#2741

Merged

6 tasks

berendt mentioned this issue Jun 5, 2024

GitHub actions based DCO check SovereignCloudStack/standards#609

Closed

genaris mentioned this issue Jun 5, 2024

fix: unqualified indy revRegDefId in migration openwallet-foundation/credo-ts#1887

Merged

zkoppert closed this as completed Jun 5, 2024

zkoppert self-assigned this Jun 5, 2024

kolyshkin mentioned this issue Jun 5, 2024

[1.1] libct/system: ClearRlimitNofileCache for go 1.23 opencontainers/runc#4299

Merged

wuhuizuo mentioned this issue Jun 6, 2024

Revert "fix(tikv/*): enable DCO plugin (#1069)" ti-community-infra/configs#1073

Merged

DEiselt added a commit to SovereignCloudStack/cluster-stacks that referenced this issue Jun 6, 2024

Dummy commit to trigger DCO

e462c7a

See dcoapp/app#211 (comment) Signed-off-by: Danny Eiselt <eiselt@b1-systems.de>

DEiselt added a commit to SovereignCloudStack/cluster-stacks that referenced this issue Jun 6, 2024

Dummy commit to retrigger DCO

f08ee8e

see dcoapp/app#211 (comment) Signed-off-by: Danny Eiselt <eiselt@b1-systems.de>

bitkeks mentioned this issue Jun 6, 2024

bump version of ip package to 2.0.1 SovereignCloudStack/status-page-web#17

Merged

nixpanic mentioned this issue Jun 6, 2024

rebase: bump sigs.k8s.io/controller-runtime from 0.18.2 to 0.18.3 in the k8s-dependencies group across 1 directory ceph/ceph-csi#4656

Merged

wlynch mentioned this issue Jun 6, 2024

resolves #516 adds support for private rekor for gitsign attest sigstore/gitsign#517

Merged

pendo324 mentioned this issue Jun 6, 2024

build(deps): Bump golang.org/x/text from 0.15.0 to 0.16.0 runfinch/finch#964

Merged

blackpiglet mentioned this issue Jun 7, 2024

fix: remove pkg/generated vmware-tanzu/velero#7627

Closed

3 tasks

qweeah mentioned this issue Jun 7, 2024

build(deps): bump golang.org/x/term from 0.20.0 to 0.21.0 oras-project/oras#1399

Merged

frouioui mentioned this issue Jun 10, 2024

Remove DCO workaround vitessio/vitess#16087

Merged

agilgur5 mentioned this issue Jun 11, 2024

fix(select): vertically center arrow argoproj/argo-ui#178

Merged

AOrthVector mentioned this issue Jul 1, 2024

DCO - Expected — Waiting for status to be reported #218

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DCO check stays as `expected` #211

DCO check stays as `expected` #211

frouioui commented Jun 3, 2024 •

edited

Loading

zkoppert commented Jun 3, 2024 •

edited

Loading

frouioui commented Jun 3, 2024

JeyJeyGao commented Jun 4, 2024 •

edited

Loading

mihaimaruseac commented Jun 5, 2024

zkoppert commented Jun 5, 2024

mihaimaruseac commented Jun 5, 2024

rbarkerSL commented Jun 5, 2024

mynameistechno commented Jun 5, 2024

frouioui commented Jun 10, 2024

DCO check stays as expected #211

DCO check stays as expected #211

Comments

frouioui commented Jun 3, 2024 • edited Loading

zkoppert commented Jun 3, 2024 • edited Loading

frouioui commented Jun 3, 2024

JeyJeyGao commented Jun 4, 2024 • edited Loading

mihaimaruseac commented Jun 5, 2024

zkoppert commented Jun 5, 2024

mihaimaruseac commented Jun 5, 2024

rbarkerSL commented Jun 5, 2024

mynameistechno commented Jun 5, 2024

frouioui commented Jun 10, 2024

DCO check stays as `expected` #211

DCO check stays as `expected` #211

frouioui commented Jun 3, 2024 •

edited

Loading

zkoppert commented Jun 3, 2024 •

edited

Loading

JeyJeyGao commented Jun 4, 2024 •

edited

Loading