sync to main #1
Merged
sync to main #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least some versions of the protobuf code for Python object to files that don't end _pb2.py, so fix that.
Updated the example: -- temperature=100 is the coldest color, not hottest -- bulb method requires three parameters: address, code and type/kind of bulb
A terrible -- but working -- solution for issue #7. The disconnection is perceived during the `recv()`, so at receiving zero bytes, we do a reconnect, reissue the command, and receive data again. Definitely not the best solution for this, but at least it is working now.
Recent firmware seems to close idle connections, so send ping packets every 10 seconds in order to discourage that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.