fix: improves JPEG parsing robustness #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses an issue where large metadata segments in JPEGs could cause parsing to fail. The changes now allow skipping segments that exceed the buffer size, enabling the parser to continue searching for the start of frame (SOF) marker and extract image dimensions. When a URL is available as the image source, it retries parsing with progressively larger buffers when initial parsing fails, accommodating images with large metadata blocks. This ensures that dimensions can be extracted even for complex JPEG images.
github-actions
bot
added
bug
rgdcastro
changed the title
rgdcastro
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue where large metadata segments in JPEGs could cause parsing to fail.
The changes now allow skipping segments that exceed the buffer size, enabling the parser to continue searching for the start of frame (SOF) marker and extract image dimensions.
When a URL is available as the image source, it retries parsing with progressively larger buffers when initial parsing fails, accommodating images with large metadata blocks. This ensures that dimensions can be extracted even for complex JPEG images.