Skip to content

Switched to the correct type #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

Conversation

stephanbouman
Copy link
Contributor

When installing the package and trying to get connected, my application tells me that I use the wrong argument type in the Storage::extend() method.

Dcblogdev\MsGraph\MsGraphServiceProvider::Dcblogdev\MsGraph\{closure}(): Argument #1 ($app) must be of type string, Illuminate\Foundation\Application given, called in /Users/stephan/Projects/playground/keurmerk-sharepoint/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemManager.php on line 162
/vendor/dcblogdev/laravel-microsoft-graph/src/MsGraphServiceProvider.php:69
 	/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemManager.php:162
 	 	 in Dcblogdev\MsGraph\MsGraphServiceProvider::Dcblogdev\MsGraph\{closure}()
 	/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemManager.php:142
 	 	 in Illuminate\Filesystem\FilesystemManager::callCustomCreator()
 	/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemManager.php:119
 	 	 in Illuminate\Filesystem\FilesystemManager::resolve()
 	/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemManager.php:82
 	 	 in Illuminate\Filesystem\FilesystemManager::get()
 	/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:361
 	 	 in Illuminate\Filesystem\FilesystemManager::disk()

As stated in the Laravel docs, the extend method accepts the Application instance as first argument.
I changed the return type to Illuminate\Foundation\Application

@dcblogdev dcblogdev merged commit 9028e65 into dcblogdev:master Jun 17, 2025
2 checks passed
@stephanbouman
Copy link
Contributor Author

@dcblogdev Would you like to tag a new release with this change? We'd like to use this in production soon :-)

@dcblogdev
Copy link
Owner

@stephanbouman sure, I've tagged a new release for you https://github.com/dcblogdev/laravel-microsoft-graph/releases/tag/v4.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants